From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9tNu-0005LM-OL for qemu-devel@nongnu.org; Fri, 29 May 2009 00:07:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9tNp-0005Jx-MR for qemu-devel@nongnu.org; Fri, 29 May 2009 00:07:57 -0400 Received: from [199.232.76.173] (port=60578 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9tNp-0005Js-DH for qemu-devel@nongnu.org; Fri, 29 May 2009 00:07:53 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54808) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9tNo-00062n-TM for qemu-devel@nongnu.org; Fri, 29 May 2009 00:07:53 -0400 Message-ID: <4A1F5ED8.40402@redhat.com> Date: Fri, 29 May 2009 00:04:40 -0400 From: john cooper MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3 References: <4A1C88DE.6050608@redhat.com> <20090527074919.GB7356@lst.de> <20090527075409.GA7926@lst.de> In-Reply-To: <20090527075409.GA7926@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: john.cooper@redhat.com, Rusty Russell , qemu-devel@nongnu.org, KVM list Christoph Hellwig wrote: > On Wed, May 27, 2009 at 09:49:19AM +0200, Christoph Hellwig wrote: >> /* >> * IDE-compatible identify ioctl. >> * >> * Currenlyt only returns the serial number and leaves all other fields >> * zero. >> */ > > Btw, thinking about it the rest of the information in the ioctl should > probably be filled up with faked data, similar to how we do it for > the ide emulation inside qemu. Agreed. I've done so to the extent it makes sense in the case of the more generic fields. A fair amount of the identify information being generated by hw/ide.c appears obsoleted. -john -- john.cooper@redhat.com