From: john cooper <john.cooper@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: john.cooper@redhat.com, Christoph Hellwig <hch@lst.de>,
KVM list <kvm@vger.kernel.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3
Date: Fri, 29 May 2009 00:05:04 -0400 [thread overview]
Message-ID: <4A1F5EF0.5090702@redhat.com> (raw)
In-Reply-To: <200905272223.27614.rusty@rustcorp.com.au>
>> + if (!(id = kzalloc(ATA_ID_WORDS, GFP_KERNEL)))
>> + rv = -ENOMEM;
>
> Doesn't ATA_ID_WORDS seem like a strange name for a number of bytes?
Yes I caught that bug in the rework as well.
> What's this *for* BTW?
Sorry -- I assumed you were on either list.
Please see patch to follow.
-john
--
john.cooper@redhat.com
next prev parent reply other threads:[~2009-05-29 4:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 0:27 [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3 john cooper
2009-05-27 7:49 ` Christoph Hellwig
2009-05-27 7:54 ` Christoph Hellwig
2009-05-29 4:04 ` john cooper
2009-05-27 12:53 ` Rusty Russell
2009-05-29 4:05 ` john cooper [this message]
2009-05-27 15:06 ` john cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1F5EF0.5090702@redhat.com \
--to=john.cooper@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).