From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9tNv-0005Ld-0a for qemu-devel@nongnu.org; Fri, 29 May 2009 00:07:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9tNp-0005K3-Px for qemu-devel@nongnu.org; Fri, 29 May 2009 00:07:58 -0400 Received: from [199.232.76.173] (port=60579 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9tNp-0005Ju-G9 for qemu-devel@nongnu.org; Fri, 29 May 2009 00:07:53 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54824) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9tNo-00069F-TS for qemu-devel@nongnu.org; Fri, 29 May 2009 00:07:53 -0400 Message-ID: <4A1F5EF0.5090702@redhat.com> Date: Fri, 29 May 2009 00:05:04 -0400 From: john cooper MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3 References: <4A1C88DE.6050608@redhat.com> <20090527074919.GB7356@lst.de> <200905272223.27614.rusty@rustcorp.com.au> In-Reply-To: <200905272223.27614.rusty@rustcorp.com.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rusty Russell Cc: john.cooper@redhat.com, Christoph Hellwig , KVM list , qemu-devel@nongnu.org >> + if (!(id = kzalloc(ATA_ID_WORDS, GFP_KERNEL))) >> + rv = -ENOMEM; > > Doesn't ATA_ID_WORDS seem like a strange name for a number of bytes? Yes I caught that bug in the rework as well. > What's this *for* BTW? Sorry -- I assumed you were on either list. Please see patch to follow. -john -- john.cooper@redhat.com