From: Anthony Liguori <aliguori@us.ibm.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: dlaor@redhat.com, ajax@redhat.com,
Paul Brook <paul@codesourcery.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Change virtio-console to PCI_CLASS_SERIAL_OTHER
Date: Fri, 29 May 2009 04:55:20 -0500 [thread overview]
Message-ID: <4A1FB108.8060608@us.ibm.com> (raw)
In-Reply-To: <1243590193.13990.73.camel@blaa>
Mark McLoughlin wrote:
> The more I think about it, no matter how much linear ABI versioning
> sucks, it's possibly the only way to solve this in a reasonably usable
> manners. Distros would just have to suck it up and agree that if they
> cherry-pick an ABI changing patch, they must update the entire ABI to
> the newer upstream ABI version.
>
If we modify pci_qdev_register() to take the savevm functions and pass
the qdev to each handler as a convention, we could then leverage the
version id of the device to implement the device versioning logic. We
would also be able to query what the current versions are in the monitor.
Moreover, we could walk the device tree before savevm to validate that
every device in the tree supports savevm which means we can fail
gracefully in when the chosen device model doesn't support live migration.
It's a large refactoring, but mostly mechanical. Any takers?
Regards,
Anthony Liguori
> Cheers,
> Mark.
>
>
next prev parent reply other threads:[~2009-05-29 9:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 17:14 [Qemu-devel] [PATCH] Change virtio-console to PCI_CLASS_SERIAL_OTHER Mark McLoughlin
2009-05-24 9:11 ` Avi Kivity
2009-05-27 14:21 ` Anthony Liguori
2009-05-27 17:42 ` Mark McLoughlin
2009-05-27 22:37 ` Anthony Liguori
2009-05-28 9:33 ` Mark McLoughlin
2009-05-28 9:44 ` Anthony Liguori
2009-05-28 12:53 ` Paul Brook
2009-05-28 12:56 ` Anthony Liguori
2009-05-28 13:22 ` Paul Brook
2009-05-28 13:29 ` Anthony Liguori
2009-05-28 21:45 ` Dor Laor
2009-05-29 9:43 ` Mark McLoughlin
2009-05-29 9:50 ` Anthony Liguori
2009-05-31 14:32 ` Avi Kivity
2009-05-29 9:55 ` Anthony Liguori [this message]
2009-05-29 10:09 ` Mark McLoughlin
2009-05-31 14:47 ` Dor Laor
2009-06-02 8:49 ` Mark McLoughlin
2009-06-02 13:08 ` Dor Laor
2009-06-02 13:39 ` Mark McLoughlin
2009-05-31 14:35 ` Dor Laor
2009-06-02 8:49 ` Mark McLoughlin
2009-05-28 13:04 ` Daniel P. Berrange
2009-05-28 13:19 ` Anthony Liguori
2009-05-31 18:48 ` Jamie Lokier
2009-05-28 13:20 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1FB108.8060608@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=ajax@redhat.com \
--cc=dlaor@redhat.com \
--cc=markmc@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).