From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9yoF-0002gu-7m for qemu-devel@nongnu.org; Fri, 29 May 2009 05:55:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9yoA-0002ZQ-0U for qemu-devel@nongnu.org; Fri, 29 May 2009 05:55:30 -0400 Received: from [199.232.76.173] (port=49491 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9yo9-0002ZB-Ql for qemu-devel@nongnu.org; Fri, 29 May 2009 05:55:25 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:56368) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M9yo9-0004eb-C1 for qemu-devel@nongnu.org; Fri, 29 May 2009 05:55:25 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4T9moAj012787 for ; Fri, 29 May 2009 03:48:50 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4T9tN8C132774 for ; Fri, 29 May 2009 03:55:23 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4T9tNIm031932 for ; Fri, 29 May 2009 03:55:23 -0600 Message-ID: <4A1FB108.8060608@us.ibm.com> Date: Fri, 29 May 2009 04:55:20 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Change virtio-console to PCI_CLASS_SERIAL_OTHER References: <1243012478.29542.18.camel@blaa> <200905281353.50463.paul@codesourcery.com> <4A1E8A16.3060101@us.ibm.com> <200905281422.52420.paul@codesourcery.com> <4A1E91AF.9050907@us.ibm.com> <4A1F05DE.6060806@redhat.com> <1243590193.13990.73.camel@blaa> In-Reply-To: <1243590193.13990.73.camel@blaa> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: dlaor@redhat.com, ajax@redhat.com, Paul Brook , qemu-devel@nongnu.org Mark McLoughlin wrote: > The more I think about it, no matter how much linear ABI versioning > sucks, it's possibly the only way to solve this in a reasonably usable > manners. Distros would just have to suck it up and agree that if they > cherry-pick an ABI changing patch, they must update the entire ABI to > the newer upstream ABI version. > If we modify pci_qdev_register() to take the savevm functions and pass the qdev to each handler as a convention, we could then leverage the version id of the device to implement the device versioning logic. We would also be able to query what the current versions are in the monitor. Moreover, we could walk the device tree before savevm to validate that every device in the tree supports savevm which means we can fail gracefully in when the chosen device model doesn't support live migration. It's a large refactoring, but mostly mechanical. Any takers? Regards, Anthony Liguori > Cheers, > Mark. > >