From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M9zlB-00049I-CS
	for qemu-devel@nongnu.org; Fri, 29 May 2009 06:56:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M9zl6-00044b-FA
	for qemu-devel@nongnu.org; Fri, 29 May 2009 06:56:25 -0400
Received: from [199.232.76.173] (port=44859 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M9zl5-00044O-W7
	for qemu-devel@nongnu.org; Fri, 29 May 2009 06:56:20 -0400
Received: from mail-qy0-f123.google.com ([209.85.221.123]:63058)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1M9zl5-0001RV-KA
	for qemu-devel@nongnu.org; Fri, 29 May 2009 06:56:19 -0400
Received: by qyk29 with SMTP id 29so6569183qyk.4
	for <qemu-devel@nongnu.org>; Fri, 29 May 2009 03:56:19 -0700 (PDT)
Message-ID: <4A1FBF4E.2060003@codemonkey.ws>
Date: Fri, 29 May 2009 05:56:14 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] use qemu_malloc and friends consistently
References: <200905290758.11551.jcd@tribudubois.net>
	<4A1F9FFE.3030100@redhat.com> <4A1FA573.4010602@codemonkey.ws>
	<Pine.LNX.4.64.0905291335130.3397@linmac.oyster.ru>
	<4A1FB37E.5040602@redhat.com>
	<Pine.LNX.4.64.0905291415010.3502@linmac.oyster.ru>
	<4A1FBA45.80902@redhat.com>
	<Pine.LNX.4.64.0905291439110.3586@linmac.oyster.ru>
	<4A1FBD9D.10400@redhat.com>
In-Reply-To: <4A1FBD9D.10400@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org, Jean-Christophe Dubois <jcd@tribudubois.net>

Kevin Wolf wrote:
> malc schrieb:
>   
>> Because of oom_check in qemu_malloc.
>>     
>
> Ok, you're right there, of course. This is a bug in qemu_malloc and the
> reason why we even discussed changing the check in qemu_malloc.
>
> But this is not qcow2's fault, so the fix should really be local to
> qemu_malloc like it already was for qemu_realloc.
>   

And Gerd's patch fixes the oom_check case for AIX along with keeping
more common malloc() semantics.

malc, do you object to me pushing Gerd's patch?

Regards,

Anthony Liguori

> Kevin
>