From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MA16V-000196-EA for qemu-devel@nongnu.org; Fri, 29 May 2009 08:22:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MA16T-00017L-TG for qemu-devel@nongnu.org; Fri, 29 May 2009 08:22:31 -0400 Received: from [199.232.76.173] (port=56632 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MA16T-00017A-NT for qemu-devel@nongnu.org; Fri, 29 May 2009 08:22:29 -0400 Received: from mx03.syneticon.net ([78.111.66.105]:51702) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MA16T-00031W-CC for qemu-devel@nongnu.org; Fri, 29 May 2009 08:22:29 -0400 Message-ID: <4A1FD397.9040904@wpkg.org> Date: Fri, 29 May 2009 14:22:47 +0200 From: Tomasz Chmielewski MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Disable kqemu by default References: <1243599100-3866-1-git-send-email-glommer@redhat.com> In-Reply-To: <1243599100-3866-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org Glauber Costa wrote: > turns -no-kqemu option into -kqemu > set kqemu_allowed to 0 by default. (...) > #ifdef CONFIG_KQEMU > -DEF("no-kqemu", 0, QEMU_OPTION_no_kqemu, \ > - "-no-kqemu disable KQEMU kernel module usage\n") > +DEF("-kqemu", 0, QEMU_OPTION_kqemu, \ > + "-kqemu enable KQEMU kernel module usage\n") Why is this change needed? Even if changed, wouldn't it be better to leave the -no-kqemu option for compatibility reasons? Otherwise, current scripts may break. -- Tomasz Chmielewski http://wpkg.org