From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MA1Ew-0005PN-0D for qemu-devel@nongnu.org; Fri, 29 May 2009 08:31:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MA1Ev-0005Ov-B4 for qemu-devel@nongnu.org; Fri, 29 May 2009 08:31:13 -0400 Received: from [199.232.76.173] (port=54309 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MA1Ev-0005Os-7F for qemu-devel@nongnu.org; Fri, 29 May 2009 08:31:13 -0400 Received: from mx03.syneticon.net ([78.111.66.105]:58765) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MA1Eu-0005SJ-QN for qemu-devel@nongnu.org; Fri, 29 May 2009 08:31:13 -0400 Message-ID: <4A1FD5A4.2010706@wpkg.org> Date: Fri, 29 May 2009 14:31:32 +0200 From: Tomasz Chmielewski MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Disable kqemu by default References: <1243599100-3866-1-git-send-email-glommer@redhat.com> <4A1FD397.9040904@wpkg.org> <20090529123047.GI30777@poweredge.glommer> In-Reply-To: <20090529123047.GI30777@poweredge.glommer> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org Glauber Costa wrote: > On Fri, May 29, 2009 at 02:22:47PM +0200, Tomasz Chmielewski wrote: >> Glauber Costa wrote: >>> turns -no-kqemu option into -kqemu >>> set kqemu_allowed to 0 by default. >> (...) >> >>> #ifdef CONFIG_KQEMU >>> -DEF("no-kqemu", 0, QEMU_OPTION_no_kqemu, \ >>> - "-no-kqemu disable KQEMU kernel module usage\n") >>> +DEF("-kqemu", 0, QEMU_OPTION_kqemu, \ >>> + "-kqemu enable KQEMU kernel module usage\n") >> Why is this change needed? > Well, we certainly need a -kqemu option to enable it, if it is disabled by default. I meant, why disable kqemu by default. -- Tomasz Chmielewski http://wpkg.org