Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel

[Jan Kiszka <jan.kiszka@siemens.com>]

Paul Brook wrote:
>>> +extern char tftp_prefix[PATH_MAX];
>>> +extern char bootp_filename[PATH_MAX];
>> This wouldn't build for me without including limits.h here
> 
> It still won't work. You can't assume PATH_MAX is defined at all.
> 

You are right, one cannot always assume its there, but we already do:

block.c:    char tmp_filename[PATH_MAX];
block.c:    char backing_filename[PATH_MAX];
qemu-char.c:    char pty_name[PATH_MAX];
...

So there must be a way to make all platforms happy qemu builds against.
Otherwise I wouldn't have used it in the first place.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux