From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MAJaA-0000sG-D0 for qemu-devel@nongnu.org; Sat, 30 May 2009 04:06:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MAJa5-0000r5-Rq for qemu-devel@nongnu.org; Sat, 30 May 2009 04:06:22 -0400 Received: from [199.232.76.173] (port=56227 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MAJa5-0000r2-P5 for qemu-devel@nongnu.org; Sat, 30 May 2009 04:06:17 -0400 Received: from mx20.gnu.org ([199.232.41.8]:25035) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MAJa5-0004Qu-50 for qemu-devel@nongnu.org; Sat, 30 May 2009 04:06:17 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MAJa4-0002QD-ED for qemu-devel@nongnu.org; Sat, 30 May 2009 04:06:16 -0400 Message-ID: <4A20E8F6.7000009@web.de> Date: Sat, 30 May 2009 10:06:14 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1243599100-3866-1-git-send-email-glommer@redhat.com> In-Reply-To: <1243599100-3866-1-git-send-email-glommer@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig04354844E071E4A88BBF1DDE" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] Disable kqemu by default List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig04354844E071E4A88BBF1DDE Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Glauber Costa wrote: > turns -no-kqemu option into -kqemu > set kqemu_allowed to 0 by default. >=20 > Signed-off-by: Glauber Costa > --- > kqemu.c | 2 +- > qemu-options.hx | 8 ++++---- > vl.c | 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/kqemu.c b/kqemu.c > index 1718498..203241e 100644 > --- a/kqemu.c > +++ b/kqemu.c > @@ -81,7 +81,7 @@ int kqemu_fd =3D KQEMU_INVALID_FD; > 1 =3D user kqemu > 2 =3D kernel kqemu > */ > -int kqemu_allowed =3D 1; > +int kqemu_allowed =3D 0; > uint64_t *pages_to_flush; > unsigned int nb_pages_to_flush; > uint64_t *ram_pages_to_update; > diff --git a/qemu-options.hx b/qemu-options.hx > index 87af798..755dc13 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1329,12 +1329,12 @@ Enable KQEMU full virtualization (default is us= er mode only). > ETEXI > =20 > #ifdef CONFIG_KQEMU > -DEF("no-kqemu", 0, QEMU_OPTION_no_kqemu, \ > - "-no-kqemu disable KQEMU kernel module usage\n") > +DEF("-kqemu", 0, QEMU_OPTION_kqemu, \ > + "-kqemu enable KQEMU kernel module usage\n") To be a bit consistent with -enable-kvm, what about -enable-kqemu? > #endif > STEXI > -@item -no-kqemu > -Disable KQEMU kernel module usage. KQEMU options are only available if= > +@item -kqemu > +Enable KQEMU kernel module usage. KQEMU options are only available if > KQEMU support is enabled when compiling. > ETEXI > =20 > diff --git a/vl.c b/vl.c > index 1a227bb..13d87de 100644 > --- a/vl.c > +++ b/vl.c > @@ -5398,8 +5398,8 @@ int main(int argc, char **argv, char **envp) > break; > #endif > #ifdef CONFIG_KQEMU > - case QEMU_OPTION_no_kqemu: > - kqemu_allowed =3D 0; > + case QEMU_OPTION_kqemu: > + kqemu_allowed =3D 1; > break; > case QEMU_OPTION_kernel_kqemu: > kqemu_allowed =3D 2; Jan --------------enig04354844E071E4A88BBF1DDE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkog6PYACgkQniDOoMHTA+ldQACeO3SNBXVKjhZsEb2m8ADoYO1Z VMUAn1pFM8RTqEWf75fdjNff9SkL83ot =BKib -----END PGP SIGNATURE----- --------------enig04354844E071E4A88BBF1DDE--