From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MAkh7-0000XZ-Qa for qemu-devel@nongnu.org; Sun, 31 May 2009 09:03:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MAkh3-0000W4-7v for qemu-devel@nongnu.org; Sun, 31 May 2009 09:03:21 -0400 Received: from [199.232.76.173] (port=58557 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MAkh3-0000W1-6C for qemu-devel@nongnu.org; Sun, 31 May 2009 09:03:17 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37122) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MAkh2-0001Fa-Hj for qemu-devel@nongnu.org; Sun, 31 May 2009 09:03:16 -0400 Message-ID: <4A22800F.8050005@redhat.com> Date: Sun, 31 May 2009 16:03:11 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] Add PCI memory region registration References: <1243157375-14329-1-git-send-email-avi@redhat.com> <1243157375-14329-3-git-send-email-avi@redhat.com> <4A1D4961.1010903@us.ibm.com> <4A1D5604.60003@redhat.com> <4A1D5837.3010705@us.ibm.com> <4A1D5B44.3040207@redhat.com> <4A1DBFC1.6060603@codemonkey.ws> In-Reply-To: <4A1DBFC1.6060603@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , qemu-devel@nongnu.org Anthony Liguori wrote: > I think it's worth looking at changing the signatures of the mem > read/write functions. Introducing a size parameter would greatly > simplify adding 64-bit IO support, for instance. I looked at this. If the caller supplies a sparse callback array this triggers the subwidth code. I don't think I understand this enough to touch it. -- error compiling committee.c: too many arguments to function