From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MB3Wa-0001uN-AQ for qemu-devel@nongnu.org; Mon, 01 Jun 2009 05:09:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MB3WV-0001s9-JK for qemu-devel@nongnu.org; Mon, 01 Jun 2009 05:09:43 -0400 Received: from [199.232.76.173] (port=37705 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MB3WV-0001rl-4c for qemu-devel@nongnu.org; Mon, 01 Jun 2009 05:09:39 -0400 Received: from mx2.redhat.com ([66.187.237.31]:52898) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MB3WU-0004nf-KD for qemu-devel@nongnu.org; Mon, 01 Jun 2009 05:09:38 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5199cRV026790 for ; Mon, 1 Jun 2009 05:09:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5199bql022650 for ; Mon, 1 Jun 2009 05:09:37 -0400 Received: from localhost.localdomain (vpn-6-7.tlv.redhat.com [10.35.6.7]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5199Z2f032045 for ; Mon, 1 Jun 2009 05:09:36 -0400 Message-ID: <4A239AEA.7030008@redhat.com> Date: Mon, 01 Jun 2009 12:10:02 +0300 From: Dor Laor MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040408040707030209010609" Subject: [Qemu-devel] [PATCH] Call qemu_bh_delete at bdrv_aio_bh_cb Reply-To: dlaor@redhat.com List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel This is a multi-part message in MIME format. --------------040408040707030209010609 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit --------------040408040707030209010609 Content-Type: text/plain; name="0001-Call-qemu_bh_delete-at-bdrv_aio_bh_cb.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-Call-qemu_bh_delete-at-bdrv_aio_bh_cb.patch" >>From 09ad82d8b8ebd1670aadf21eae8021dfad373c61 Mon Sep 17 00:00:00 2001 From: Dor Laor Date: Mon, 1 Jun 2009 12:07:23 +0300 Subject: [PATCH] Call qemu_bh_delete at bdrv_aio_bh_cb. Also replave qemu_bh_cancel with qemu_bh_delete in bdrv_aio_cancel_em. Otherwise the bh will live forever in the bh list. Signed-off-by: Dor Laor --- block.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index c80d4b9..4a0b642 100644 --- a/block.c +++ b/block.c @@ -1402,7 +1402,7 @@ static void bdrv_aio_bh_cb(void *opaque) qemu_iovec_from_buffer(acb->qiov, acb->bounce, acb->qiov->size); qemu_vfree(acb->bounce); acb->common.cb(acb->common.opaque, acb->ret); - + qemu_bh_delete(acb->bh); qemu_aio_release(acb); } @@ -1455,7 +1455,7 @@ static BlockDriverAIOCB *bdrv_aio_writev_em(BlockDriverState *bs, static void bdrv_aio_cancel_em(BlockDriverAIOCB *blockacb) { BlockDriverAIOCBSync *acb = (BlockDriverAIOCBSync *)blockacb; - qemu_bh_cancel(acb->bh); + qemu_bh_delete(acb->bh); qemu_aio_release(acb); } -- 1.5.6.6 --------------040408040707030209010609--