From: Jan Kiszka <jan.kiszka@web.de>
To: Nitin A Kamble <nitin.a.kamble@intel.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] QEMU KVM: i386: Fix the cpu reset state
Date: Sat, 06 Jun 2009 09:46:04 +0200 [thread overview]
Message-ID: <4A2A1EBC.1070702@web.de> (raw)
In-Reply-To: <1244150990-8234-1-git-send-email-nitin.a.kamble@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2324 bytes --]
Nitin A Kamble wrote:
> As per the IA32 processor manual, the accessed bit is set to 1 in the
> processor state after reset. qemu pc cpu_reset code was missing this
> accessed bit setting.
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
> target-i386/helper.c | 18 ++++++++++++------
> 1 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 7fc5366..573fb5b 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -493,17 +493,23 @@ void cpu_reset(CPUX86State *env)
> env->tr.flags = DESC_P_MASK | (11 << DESC_TYPE_SHIFT);
>
> cpu_x86_load_seg_cache(env, R_CS, 0xf000, 0xffff0000, 0xffff,
> - DESC_P_MASK | DESC_S_MASK | DESC_CS_MASK | DESC_R_MASK);
> + DESC_P_MASK | DESC_S_MASK | DESC_CS_MASK |
> + DESC_R_MASK | DESC_A_MASK);
> cpu_x86_load_seg_cache(env, R_DS, 0, 0, 0xffff,
> - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK);
> + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
> + DESC_A_MASK);
> cpu_x86_load_seg_cache(env, R_ES, 0, 0, 0xffff,
> - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK);
> + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
> + DESC_A_MASK);
> cpu_x86_load_seg_cache(env, R_SS, 0, 0, 0xffff,
> - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK);
> + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
> + DESC_A_MASK);
> cpu_x86_load_seg_cache(env, R_FS, 0, 0, 0xffff,
> - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK);
> + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
> + DESC_A_MASK);
> cpu_x86_load_seg_cache(env, R_GS, 0, 0, 0xffff,
> - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK);
> + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
> + DESC_A_MASK);
>
> env->eip = 0xfff0;
> env->regs[R_EDX] = env->cpuid_version;
Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
Thanks,
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
prev parent reply other threads:[~2009-06-06 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <i386_cpu_reset>
2009-06-04 21:29 ` [Qemu-devel] [PATCH] QEMU KVM: i386: Fix the cpu reset state Nitin A Kamble
2009-06-06 7:46 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2A1EBC.1070702@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nitin.a.kamble@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).