From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MCqbd-0005Lk-LD for qemu-devel@nongnu.org; Sat, 06 Jun 2009 03:46:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MCqbY-0005Dp-UZ for qemu-devel@nongnu.org; Sat, 06 Jun 2009 03:46:21 -0400 Received: from [199.232.76.173] (port=45644 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCqbY-0005Df-RL for qemu-devel@nongnu.org; Sat, 06 Jun 2009 03:46:16 -0400 Received: from mx20.gnu.org ([199.232.41.8]:8161) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MCqbY-0001Yr-BV for qemu-devel@nongnu.org; Sat, 06 Jun 2009 03:46:16 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MCqbW-00011n-FK for qemu-devel@nongnu.org; Sat, 06 Jun 2009 03:46:14 -0400 Message-ID: <4A2A1EBC.1070702@web.de> Date: Sat, 06 Jun 2009 09:46:04 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1244150990-8234-1-git-send-email-nitin.a.kamble@intel.com> In-Reply-To: <1244150990-8234-1-git-send-email-nitin.a.kamble@intel.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE0128A82395016E79F936CB4" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] QEMU KVM: i386: Fix the cpu reset state List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nitin A Kamble Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE0128A82395016E79F936CB4 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Nitin A Kamble wrote: > As per the IA32 processor manual, the accessed bit is set to 1 in the > processor state after reset. qemu pc cpu_reset code was missing this > accessed bit setting. >=20 > Signed-off-by: Nitin A Kamble > --- > target-i386/helper.c | 18 ++++++++++++------ > 1 files changed, 12 insertions(+), 6 deletions(-) >=20 > diff --git a/target-i386/helper.c b/target-i386/helper.c > index 7fc5366..573fb5b 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -493,17 +493,23 @@ void cpu_reset(CPUX86State *env) > env->tr.flags =3D DESC_P_MASK | (11 << DESC_TYPE_SHIFT); > =20 > cpu_x86_load_seg_cache(env, R_CS, 0xf000, 0xffff0000, 0xffff, > - DESC_P_MASK | DESC_S_MASK | DESC_CS_MASK | = DESC_R_MASK); > + DESC_P_MASK | DESC_S_MASK | DESC_CS_MASK | > + DESC_R_MASK | DESC_A_MASK); > cpu_x86_load_seg_cache(env, R_DS, 0, 0, 0xffff, > - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK); > + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK | > + DESC_A_MASK); > cpu_x86_load_seg_cache(env, R_ES, 0, 0, 0xffff, > - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK); > + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK | > + DESC_A_MASK); > cpu_x86_load_seg_cache(env, R_SS, 0, 0, 0xffff, > - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK); > + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK | > + DESC_A_MASK); > cpu_x86_load_seg_cache(env, R_FS, 0, 0, 0xffff, > - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK); > + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK | > + DESC_A_MASK); > cpu_x86_load_seg_cache(env, R_GS, 0, 0, 0xffff, > - DESC_P_MASK | DESC_S_MASK | DESC_W_MASK); > + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK | > + DESC_A_MASK); > =20 > env->eip =3D 0xfff0; > env->regs[R_EDX] =3D env->cpuid_version; Acked-by: Jan Kiszka Thanks, Jan --------------enigE0128A82395016E79F936CB4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkoqHsEACgkQniDOoMHTA+n8JACfTZVJY3wBgFIJPIw/+2pYFF57 RhEAn2t9I4WtSTaQvVdNy7zxjh7GUi4b =NqF9 -----END PGP SIGNATURE----- --------------enigE0128A82395016E79F936CB4--