From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MDEwf-00082A-Pa
	for qemu-devel@nongnu.org; Sun, 07 Jun 2009 05:45:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MDEwa-0007y1-H6
	for qemu-devel@nongnu.org; Sun, 07 Jun 2009 05:45:40 -0400
Received: from [199.232.76.173] (port=49588 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MDEwa-0007xk-7M
	for qemu-devel@nongnu.org; Sun, 07 Jun 2009 05:45:36 -0400
Received: from mx2.redhat.com ([66.187.237.31]:46392)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MDEwZ-0004X8-Ki
	for qemu-devel@nongnu.org; Sun, 07 Jun 2009 05:45:35 -0400
Message-ID: <4A2B8C36.6010307@redhat.com>
Date: Sun, 07 Jun 2009 12:45:26 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4A2B88B1.4060005@web.de> <4A2B8A9F.4060709@redhat.com>
	<4A2B8B15.8090203@web.de>
In-Reply-To: <4A2B8B15.8090203@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] kvm: Improve upgrade notes when facing
	unsupported kernels
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, =?ISO-8859-15?Q?Andreas_F=E4?=@gnu.org, =?ISO-8859-15?Q?rber?= <andreas.faerber@web.de>, qemu-devel <qemu-devel@nongnu.org>

Jan Kiszka wrote:
> Avi Kivity wrote:
>   
>> Jan Kiszka wrote:
>>     
>>> Users complained that it is not obvious what to do when kvm refuses to
>>> build or run due to an unsupported host kernel, so let's improve the
>>> hints.
>>>
>>> diff --git a/configure b/configure
>>> index 42d46f2..8ccb58c 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -1158,7 +1158,9 @@ EOF
>>>      | grep "error: " \
>>>      | awk -F "error: " '{if (NR>1) printf(", "); printf("%s",$2);}'`
>>>        if test "$kvmerr" != "" ; then
>>> -        kvm="no - (${kvmerr})"
>>> +        kvm="no - (${kvmerr})\n\
>>> +    NOTE: To enable KVM support, update your kernel to 2.6.29+ or
>>> install \
>>> +recent kvm-kmod from http://sourceforge.net/projects/kvm."
>>>        fi
>>>   
>>>       
>> Installing kvm-mod is insufficient, you need the headers from somewhere.
>>
>>     
>
> True. Hmm, wasn't there the plan to fix this by carrying them in-tree?
>   

Anthony even posted a patch but it was a bit excessive, carrying tons of 
kernel headers.  I think we'd be fine carrying just the kvm headers, 
same as qemu-kvm.  In which case the compile time test can go away.

Alternatively, I can make kvm-kmod install the necessary headers to 
/usr/local/include.  It's probably cleaner this way.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.