From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MDYqO-0003fZ-JN
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 03:00:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MDYqJ-0003Xa-ST
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 03:00:32 -0400
Received: from [199.232.76.173] (port=35336 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MDYqJ-0003XD-N9
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 03:00:27 -0400
Received: from mx20.gnu.org ([199.232.41.8]:47630)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1MDYqI-0006XV-Vi
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 03:00:27 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MDYqH-00075B-OW
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 03:00:26 -0400
Message-ID: <4A2CB700.5070202@redhat.com>
Date: Mon, 08 Jun 2009 09:00:16 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] xen: net backend doesn't need linux headers.
References: <1243926324-13133-1-git-send-email-kraxel@redhat.com>
	<f43fc5580906060852i671ee4a0ie575ce061271d9a2@mail.gmail.com>
	<28EBEC28-6D03-4321-8629-1F54EA30C634@web.de>
In-Reply-To: <28EBEC28-6D03-4321-8629-1F54EA30C634@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, xen-devel@lists.xensource.com, qemu-devel@nongnu.org

On 06/06/09 21:43, Andreas F=E4rber wrote:
> In file included from /export/home/andreas/QEMU/qemu/hw/xen_disk.c:43:
> /export/home/andreas/QEMU/qemu/hw/xen_blkif.h:20: warning: #pragma
> pack(push[, id], <n>) is not supported on this target
> /export/home/andreas/QEMU/qemu/hw/xen_blkif.h:36: warning: #pragma
> pack(pop[, id], <n>) is not supported on this target
> CC xen_nic.o

Hmm, is this a x86 or sparc machine?

> /export/home/andreas/QEMU/qemu/hw/xen_nic.c:179: error: `PAGE_SIZE'
> undeclared (first use in this function)

> Looking at the code though I see a number of XC_PAGE_SIZE that don't
> result in errors. Might PAGE_SIZE be a typo then?

Yes, XC_PAGE_SIZE should be used here.

cheers,
   Gerd