Re: [Qemu-devel] [PATCH] xen: net backend doesn't need linux headers.

[Gerd Hoffmann <kraxel@redhat.com>]

On 06/07/09 08:56, Blue Swirl wrote:
>>   -                    tmpbuf = malloc(PAGE_SIZE);
>>   +                    tmpbuf = malloc(XC_PAGE_SIZE);

> It also looks like there is no real need for using host or target page
> size, so we could use for example MIN(4096,  txreq.size).

No.  XC_PAGE_SIZE is the max buffer size.  As the buffer allocated here 
could be resused for multiple packets you'll have to use that, otherwise 
you'll overflow the buffer in case the second packet is larger than the 
first one.

>>   If then goes on to compile Xen stuff into sparc-softmmu and fails:

Hmm, it shouldn't try that in the first place.  Guess this is the result 
of this commit:

http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=2567f5796c38238d6f2055f074e347a0338140ce

>>   xc_gnttab_open
>>   collect2: ld returned 1 exit status
>>   Same errors when linking i386-softmmu.

For i386-softmmu it should work.

> configure should probe for xc_gnttab symbols and disable Xen if these
> are not found.

Strange.  configure checks for xc_interface_open.  Both 
xc_interface_open and xc_gnttab_open are in the same shared library.  So 
it should work in theory, dunno what the problem here is.

Hmm, the linker complains about xc_gnttab_* only, not about the other 
xc_* functions missing.  Maybe solaris simply has no support for them?

cheers,
   Gerd