qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qdev: hook up i440fx pcihost to system bus.
Date: Mon, 08 Jun 2009 16:04:01 +0200	[thread overview]
Message-ID: <4A2D1A51.309@redhat.com> (raw)
In-Reply-To: <200906081404.28277.paul@codesourcery.com>

On 06/08/09 15:04, Paul Brook wrote:
>> typedef struct {
>> +    DeviceState qdev;
>> ...
>> +static struct DeviceInfo i440fx_pcihost_devinfo = {
>> +    .init = i440fx_initfn,
>> +    .bus_type = BUS_TYPE_SYSTEM,
>> +};
>
> This is clearly a lie.

--verbose please.

Ok, looks like main_system_bus (qdev.c) is supposed to be the root bus. 
  Is that correct?  If so, then we'll have to link the (primary) pci bus 
to the system bus, so the devices show up in the device tree.

Or is the main_system_bus meant for embedded boards only which have some 
non-standard bus?  In that case we'll needs some way to tell qdev what 
the root bus is, so qdev can operate on the tree.  For now this is just 
printing the devices in "info qtree", but I'm sure one day we will do 
much more with the device tree.

cheers,
   Gerd

  reply	other threads:[~2009-06-08 14:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 12:33 [Qemu-devel] [PATCH] qdev: hook up i440fx pcihost to system bus Gerd Hoffmann
2009-06-08 13:04 ` Paul Brook
2009-06-08 14:04   ` Gerd Hoffmann [this message]
2009-06-08 14:53     ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2D1A51.309@redhat.com \
    --to=kraxel@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).