From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MDfUM-0005WI-6Q
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 10:06:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MDfUH-0005Pp-JA
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 10:06:13 -0400
Received: from [199.232.76.173] (port=54233 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MDfUH-0005PU-9Y
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 10:06:09 -0400
Received: from mx2.redhat.com ([66.187.237.31]:34548)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MDfUG-0005sc-Ej
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 10:06:08 -0400
Message-ID: <4A2D1A51.309@redhat.com>
Date: Mon, 08 Jun 2009 16:04:01 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] qdev: hook up i440fx pcihost to system bus.
References: <1244464428-3795-1-git-send-email-kraxel@redhat.com>
	<200906081404.28277.paul@codesourcery.com>
In-Reply-To: <200906081404.28277.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On 06/08/09 15:04, Paul Brook wrote:
>> typedef struct {
>> +    DeviceState qdev;
>> ...
>> +static struct DeviceInfo i440fx_pcihost_devinfo = {
>> +    .init = i440fx_initfn,
>> +    .bus_type = BUS_TYPE_SYSTEM,
>> +};
>
> This is clearly a lie.

--verbose please.

Ok, looks like main_system_bus (qdev.c) is supposed to be the root bus. 
  Is that correct?  If so, then we'll have to link the (primary) pci bus 
to the system bus, so the devices show up in the device tree.

Or is the main_system_bus meant for embedded boards only which have some 
non-standard bus?  In that case we'll needs some way to tell qdev what 
the root bus is, so qdev can operate on the tree.  For now this is just 
printing the devices in "info qtree", but I'm sure one day we will do 
much more with the device tree.

cheers,
   Gerd