From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDfTt-0004mS-Mw for qemu-devel@nongnu.org; Mon, 08 Jun 2009 10:05:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDfTo-0004eN-Io for qemu-devel@nongnu.org; Mon, 08 Jun 2009 10:05:45 -0400 Received: from [199.232.76.173] (port=54217 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDfTm-0004dr-UI for qemu-devel@nongnu.org; Mon, 08 Jun 2009 10:05:40 -0400 Received: from gecko.sbs.de ([194.138.37.40]:22734) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MDfTm-0005nY-7q for qemu-devel@nongnu.org; Mon, 08 Jun 2009 10:05:38 -0400 Message-ID: <4A2D1AAF.4090406@siemens.com> Date: Mon, 08 Jun 2009 16:05:35 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1244465766-6349-1-git-send-email-gleb@redhat.com> In-Reply-To: <1244465766-6349-1-git-send-email-gleb@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/3] Add rtc reset function. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org Gleb Natapov wrote: > On reset: > Periodic Interrupt Enable (PIE) bit is cleared to zero > Alarm Interrupt Enable (AIE) bit is cleared to zero > Update ended Interrupt Flag (UF) bit is cleared to zero > Interrupt Request status Flag (IRQF) bit is cleared to zero > Periodic Interrupt Flag (PF) bit is cleared to zero > Alarm Interrupt Flag (AF) bit is cleared to zero > Square Wave output Enable (SQWE) zero > > Signed-off-by: Gleb Natapov > --- > hw/mc146818rtc.c | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c > index 888b85a..98a2273 100644 > --- a/hw/mc146818rtc.c > +++ b/hw/mc146818rtc.c > @@ -568,6 +568,22 @@ static int rtc_load_td(QEMUFile *f, void *opaque, int version_id) > } > #endif > > +static void rtc_reset(void *opaque) > +{ > + RTCState *s = opaque; > + > + /* clear PIE,AIE,SQWE on reset */ > + s->cmos_data[RTC_REG_B] &= ~((1<<6) | (1<<5) | (1<<3)); > + > + /* clear UF,IRQF,PF,AF on reset */ > + s->cmos_data[RTC_REG_C] &= ~((1<<4) | (1<<7) | (1<<6) | (1<<5)); Didn't check what the rest of this file does, but maybe it's a chance to give those bits names, ie. #define something. > + > +#ifdef TARGET_I386 > + if (rtc_td_hack) > + s->irq_coalesced = 0; > +#endif > +} > + > RTCState *rtc_init_sqw(int base, qemu_irq irq, qemu_irq sqw_irq, int base_year) > { > RTCState *s; > @@ -606,6 +622,8 @@ RTCState *rtc_init_sqw(int base, qemu_irq irq, qemu_irq sqw_irq, int base_year) > if (rtc_td_hack) > register_savevm("mc146818rtc-td", base, 1, rtc_save_td, rtc_load_td, s); > #endif > + qemu_register_reset(rtc_reset, 0, s); > + > return s; > } > > @@ -721,5 +739,6 @@ RTCState *rtc_mm_init(target_phys_addr_t base, int it_shift, qemu_irq irq, > if (rtc_td_hack) > register_savevm("mc146818rtc-td", base, 1, rtc_save_td, rtc_load_td, s); > #endif > + qemu_register_reset(rtc_reset, 0, s); > return s; > } Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux