qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yaniv Kamay <ykamay@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] Add pci_bus_reset() function.
Date: Mon, 08 Jun 2009 17:42:49 +0300	[thread overview]
Message-ID: <4A2D2369.5090805@redhat.com> (raw)
In-Reply-To: <20090608143710.GM27210@redhat.com>

Gleb Natapov wrote:
> On Mon, Jun 08, 2009 at 05:35:11PM +0300, Avi Kivity wrote:
>   
>> Gleb Natapov wrote:
>>     
>>> To reset internal irq handling data structures.
>>>
>>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>>> Signed-off-by: Yaniv Kamay <ykamay@redhat.com>
>>> ---
>>>  hw/pci.c |   16 ++++++++++++++++
>>>  1 files changed, 16 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/pci.c b/hw/pci.c
>>> index 02b335f..89fefdf 100644
>>> --- a/hw/pci.c
>>> +++ b/hw/pci.c
>>> @@ -88,6 +88,21 @@ static int  pcibus_load(QEMUFile *f, void *opaque, int version_id)
>>>      return 0;
>>>  }
>>>  +static void pci_bus_reset(void *opaque)
>>> +{
>>> +    PCIBus *bus = (PCIBus *)opaque;
>>> +    int i;
>>> +
>>> +    for (i = 0; i < bus->nirq; i++) {
>>> +        bus->irq_count[i] = 0;
>>> +    }
>>> +    for (i = 0; i < PCI_DEVICES_MAX; i++) {
>>> +        if (bus->devices[i])
>>> +            memset(bus->devices[i]->irq_state, 0,
>>> +                   sizeof(bus->devices[i]->irq_state));
>>> +    }
>>> +}
>>> +
>>>   
>>>       
>> Shouldn't each device's reset function bring its line low, thus zeroing  
>> the irq_state naturally?
>>
>> If not, we have a bug somewhere.  Note we have exactly the same issue  
>> with save/restore.
>>
>>     
> They should, but I haven't found one that does.
>   

This is matter of definitions and not right or wrong, Since PCI in 
current imp save and load its state then it only logical that PCI will 
also reset it state.

Yaniv

> --
> 			Gleb.
>   

  reply	other threads:[~2009-06-08 14:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 12:56 [Qemu-devel] [PATCH 1/3] Add rtc reset function Gleb Natapov
2009-06-08 12:56 ` [Qemu-devel] [PATCH 2/3] Add pci_bus_reset() function Gleb Natapov
2009-06-08 14:35   ` Avi Kivity
2009-06-08 14:37     ` Gleb Natapov
2009-06-08 14:42       ` Yaniv Kamay [this message]
2009-06-08 21:42       ` Dor Laor
2009-06-09  5:31         ` Gleb Natapov
2009-06-09 15:07           ` Blue Swirl
2009-06-09 15:24             ` Gleb Natapov
2009-06-09 15:53             ` Gleb Natapov
2009-06-09 16:07               ` Blue Swirl
2009-06-08 12:56 ` [Qemu-devel] [PATCH 3/3] Call piix3_reset() on system reset Gleb Natapov
2009-06-08 14:05 ` [Qemu-devel] Re: [PATCH 1/3] Add rtc reset function Jan Kiszka
2009-06-08 14:13   ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2D2369.5090805@redhat.com \
    --to=ykamay@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).