From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MDgUw-0005z3-Iw
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 11:10:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MDgUv-0005yi-PR
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 11:10:54 -0400
Received: from [199.232.76.173] (port=51442 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MDgUv-0005yf-GK
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 11:10:53 -0400
Received: from mx03.syneticon.net ([78.111.66.105]:46043)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mangoo@wpkg.org>) id 1MDgUv-0006Sb-4C
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 11:10:53 -0400
Message-ID: <4A2D2A16.3030400@wpkg.org>
Date: Mon, 08 Jun 2009 17:11:18 +0200
From: Tomasz Chmielewski <mangoo@wpkg.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [SOLUTION] "i8042.c: No controller found" -> OS
	sees no keyboard if I type "in BIOS"
References: <4A0C232D.1020201@wpkg.org> <4A13CDC4.3000704@wpkg.org>
	<4A1405E1.70405@wpkg.org> <20090607040410.GA25831@amt.cnet>
	<4A2D1752.1080004@wpkg.org> <4A2D1C75.2040006@wpkg.org>
	<20090608143021.GA6107@amt.cnet>
In-Reply-To: <20090608143021.GA6107@amt.cnet>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Marcelo Tosatti wrote:

>>> PS2_QUEUE_SIZE 256 was introduced in qemu-0.8.0.
>> BTW, with "PS2_QUEUE_SIZE 16" I'm still able to trigger:
>>
>> i8042.c: No controller found.
> 
> I was not able to trigger it by changing PS2_QUEUE_SIZE to 16 (which
> shows the testing was lame, since you did trigger it).

For me, moving mouse adds to the buffer really fast.


>> Only with "PS2_QUEUE_SIZE 15" keyboard is detected every time I boot the  
>> guest (unless that's what you meant by setting it to 16).
> 
> No, 16. Maybe there's some off-by-one bug in hw/ps2.c? Also yesterday i
> was not entirely sure the KBD_STAT_OBF (output buffer empty/full status
> bit) handling was correct (thus the attached patch), but now a quick
> look seems to indicate it is alright, since it be will update these bits
> via:

(...)

> -#define PS2_QUEUE_SIZE 256
> +#define PS2_QUEUE_SIZE 16

15? With 16 it can still break (broken BIOS?).


-- 
Tomasz Chmielewski
http://wpkg.org