From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDmmy-0003P2-7X for qemu-devel@nongnu.org; Mon, 08 Jun 2009 17:53:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDmmt-0003Ky-IK for qemu-devel@nongnu.org; Mon, 08 Jun 2009 17:53:55 -0400 Received: from [199.232.76.173] (port=39835 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDmmt-0003Ku-Dp for qemu-devel@nongnu.org; Mon, 08 Jun 2009 17:53:51 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:54712) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MDmmt-0005YF-0d for qemu-devel@nongnu.org; Mon, 08 Jun 2009 17:53:51 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n58LponN026497 for ; Mon, 8 Jun 2009 15:51:50 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n58Lrnee227142 for ; Mon, 8 Jun 2009 15:53:49 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n58LrnpR029133 for ; Mon, 8 Jun 2009 15:53:49 -0600 Message-ID: <4A2D886C.5020007@us.ibm.com> Date: Mon, 08 Jun 2009 16:53:48 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1244497683-14391-1-git-send-email-aliguori@us.ibm.com> <1244497683-14391-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1244497683-14391-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org Anthony Liguori wrote: > This is needed for VMware VGA to work properly under KVM. > > Signed-off-by: Anthony Liguori > --- > hw/vmware_vga.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c > index bb17698..246011b 100644 > --- a/hw/vmware_vga.c > +++ b/hw/vmware_vga.c > @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev, int region_num, > #endif > cpu_register_physical_memory(s->vram_base, s->vga.vram_size, > iomemtype); > + > + s->vga.map_addr = addr; > + s->vga.map_end = addr + s->vga.vram_size; > + vga_dirty_log_start(&s->vga); > } > > void pci_vmsvga_init(PCIBus *bus) > N.B. depth is still screwed up with VMware vga but the fix for that looks a bit more non-obvious. This VBE issue has been a long standing problem though and I suspect it effects other guests though. -- Regards, Anthony Liguori