From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MDs9F-0005xa-Pv
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 23:37:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MDs9A-0005xN-72
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 23:37:16 -0400
Received: from [199.232.76.173] (port=36744 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MDs9A-0005xK-1d
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 23:37:12 -0400
Received: from mx2.redhat.com ([66.187.237.31]:57557)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MDs99-000155-Ia
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 23:37:11 -0400
Message-ID: <4A2DD8EC.1070503@redhat.com>
Date: Tue, 09 Jun 2009 06:37:16 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1244497683-14391-1-git-send-email-aliguori@us.ibm.com>
	<1244497683-14391-2-git-send-email-aliguori@us.ibm.com>
	<loom.20090609T011827-203@post.gmane.org>
In-Reply-To: <loom.20090609T011827-203@post.gmane.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] Make sure to enable dirty log tracking
 for VMware VGA
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nolan <nolan@sigbus.net>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, kvm@vger.kernel.org

(redirecting)

Nolan wrote:
> Anthony Liguori <aliguori <at> us.ibm.com> writes:
>   
>>  
>> This is needed for VMware VGA to work properly under KVM.
>>
>> Signed-off-by: Anthony Liguori <aliguori <at> us.ibm.com>
>> ---
>>  hw/vmware_vga.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
>> index bb17698..246011b 100644
>> --- a/hw/vmware_vga.c
>> +++ b/hw/vmware_vga.c
>> @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev, int
>>     
> region_num,
>   
>>  #endif
>>      cpu_register_physical_memory(s->vram_base, s->vga.vram_size,
>>                      iomemtype);
>> +
>> +    s->vga.map_addr = addr;
>> +    s->vga.map_end = addr + s->vga.vram_size;
>> +    vga_dirty_log_start(&s->vga);
>>  }
>>
>>  void pci_vmsvga_init(PCIBus *bus)
>>     
>
> Using the MMU to track writes to VRAM should only be needed when the FIFO is
> disabled.  When the FIFO is enabled (SVGA_REG_CONFIG_DONE = 1), the guest will
> notify the host via the FIFO when it has written to a region of VRAM directly,
> using the SVGA_CMD_UPDATE FIFO command.
>
> Unless I'm confused, this change appears to use the MMU to track VRAM updates
> unconditionally.
>   


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.