From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ME3Dw-000607-SD
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:26:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ME3Ds-0005yL-FW
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:26:52 -0400
Received: from [199.232.76.173] (port=40832 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ME3Ds-0005yG-8j
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:26:48 -0400
Received: from mx2.redhat.com ([66.187.237.31]:47145)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1ME3Dr-0006ng-Pz
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:26:48 -0400
Message-ID: <4A2E7EBA.1060805@redhat.com>
Date: Tue, 09 Jun 2009 17:24:42 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic
References: <1244545261-23679-1-git-send-email-kraxel@redhat.com>
	<200906091601.41592.paul@codesourcery.com>
In-Reply-To: <200906091601.41592.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On 06/09/09 17:01, Paul Brook wrote:
>> +    qdev_init_gpio_out(&sysdev->qdev,&s->parent_irq, 1);
>
> This should be using sysbus_init_irq.
>
> Paul

Patch 3/3 kills that line anyway ...

cheers,
   Gerd