From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ME3dk-0003pK-11
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:53:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ME3de-0003n3-9d
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:53:30 -0400
Received: from [199.232.76.173] (port=47182 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ME3de-0003n0-0c
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:53:26 -0400
Received: from mx2.redhat.com ([66.187.237.31]:41933)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1ME3dd-0005ng-Fo
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:53:25 -0400
Message-ID: <4A2E84F8.7020303@redhat.com>
Date: Tue, 09 Jun 2009 17:51:20 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic
References: <1244545261-23679-1-git-send-email-kraxel@redhat.com>
	<200906091601.41592.paul@codesourcery.com>
	<4A2E7EBA.1060805@redhat.com>
	<200906091632.19195.paul@codesourcery.com>
In-Reply-To: <200906091632.19195.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On 06/09/09 17:32, Paul Brook wrote:
> On Tuesday 09 June 2009, Gerd Hoffmann wrote:
>> On 06/09/09 17:01, Paul Brook wrote:
>>>> +    qdev_init_gpio_out(&sysdev->qdev,&s->parent_irq, 1);
>>> This should be using sysbus_init_irq.
>>>
>>> Paul
>> Patch 3/3 kills that line anyway ...
>
> It's still wrong.

Why doesn't sysbus_init_irq() call qdev_init_gpio_out()?

What is the point in maintaining qemu_irqs in SysBusDevice directly and 
ignoring the qemu_irqs in DeviceState (aka SysBusDevice.qdev)?

cheers,
   Gerd