From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ME4Oo-0005i7-2f for qemu-devel@nongnu.org; Tue, 09 Jun 2009 12:42:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ME4Ok-0005ZS-4J for qemu-devel@nongnu.org; Tue, 09 Jun 2009 12:42:09 -0400 Received: from [199.232.76.173] (port=49809 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ME4Oj-0005ZI-NK for qemu-devel@nongnu.org; Tue, 09 Jun 2009 12:42:05 -0400 Received: from mx2.redhat.com ([66.187.237.31]:33588) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ME4Oj-0007jj-AM for qemu-devel@nongnu.org; Tue, 09 Jun 2009 12:42:05 -0400 Message-ID: <4A2E90D9.60908@redhat.com> Date: Tue, 09 Jun 2009 19:42:01 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h References: <1244563466-32598-1-git-send-email-glommer@redhat.com> <4A2E8B15.3010401@siemens.com> <4A2E8D52.4080600@redhat.com> <20090609163906.GO11966@poweredge.glommer> In-Reply-To: <20090609163906.GO11966@poweredge.glommer> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Jan Kiszka , aliguori@us.ibm.com, qemu-devel@nongnu.org Glauber Costa wrote: >> Yes, we could simply append libkvm-all.c and qemu-kvm.c to kvm-all.c, >> and gradually include more of kvm-all.c as we delete parts of libkvm.c >> and qemu-kvm.c. >> > I tried it myself, and it generates tons of conflicts. So scary. > I'd prefer to do it in the way I propose, until there is nothing left on kvm-all.c > There shouldn't be any conflicts, kvm-all is ifdefed out. We'd enable bits one by one until everything is enabled. -- error compiling committee.c: too many arguments to function