[Qemu-devel] [PATCH] Remove the default "nowait" option from gdb stubs tcp connection

[Qemu-devel] [PATCH] Remove the default "nowait" option from gdb stubs tcp connection

[bahadir balban]

Remove the default "nowait" option from gdb stubs tcp connection

The tcp connection in gdb stubs has "nowait" option set by default,
which causes QEMU to continue without waiting for a gdb connection as opposed
to the documented: "-s  Wait gdb connection to port 1234." behaviour.

Signed-off-by: Bahadir Balban <bbalban@b-labs.co.uk>
---

 gdbstub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdbstub.c b/gdbstub.c
index 9bd4375..7d9a2f5 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2396,7 +2396,7 @@ int gdbserver_start(const char *device)
         if (strstart(device, "tcp:", NULL)) {
             /* enforce required TCP attributes */
             snprintf(gdbstub_device_name, sizeof(gdbstub_device_name),
-                     "%s,nowait,nodelay,server", device);
+                     "%s,nodelay,server", device);
             device = gdbstub_device_name;
         }
 #ifndef _WIN32

Re: [Qemu-devel] [PATCH] Remove the default "nowait" option from gdb stubs tcp connection

[Paul Brook]

On Tuesday 09 June 2009, bahadir balban wrote:
> Remove the default "nowait" option from gdb stubs tcp connection
>
> The tcp connection in gdb stubs has "nowait" option set by default,
> which causes QEMU to continue without waiting for a gdb connection as
> opposed to the documented: "-s  Wait gdb connection to port 1234."
> behaviour.

No. The current behavior is correct. If you want qemu to stop guest execution 
then use the -S option.

Paul

[Qemu-devel] Re: [PATCH] Remove the default "nowait" option from gdb stubs tcp connection

[Jan Kiszka]

bahadir balban wrote:
> Remove the default "nowait" option from gdb stubs tcp connection
> 
> The tcp connection in gdb stubs has "nowait" option set by default,
> which causes QEMU to continue without waiting for a gdb connection as opposed
> to the documented: "-s  Wait gdb connection to port 1234." behaviour.

The patch is wrong as Paul stated, but your remark about the
documentation is valid. So please post a clarifying doc patch against
qemu.git.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

[Qemu-devel] Re: [PATCH] Remove the default "nowait" option from gdb stubs tcp connection

[bahadir balban]

On Tue, Jun 9, 2009 at 4:43 PM, Jan Kiszka<jan.kiszka@siemens.com> wrote:
>
> The patch is wrong as Paul stated, but your remark about the
> documentation is valid. So please post a clarifying doc patch against
> qemu.git.
>
> Thanks,
> Jan
>

Hmm, OK. Is there any use case where -s is used without -S? GDB
connecting at an arbitrary time during execution did not make sense to
me. If I created a small patch with "nowait" as an option would you
consider it? Most tcp connection options seem to have it.

As per the docs, -S requires user to press 'c' to continue whereas
with a waiting -s I can use a .gdbinit script to automate debugging.


Thanks,

Bahadir

[Qemu-devel] Re: [PATCH] Remove the default "nowait" option from gdb stubs tcp connection

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

bahadir balban wrote:
> On Tue, Jun 9, 2009 at 4:43 PM, Jan Kiszka<jan.kiszka@siemens.com> wrote:
>> The patch is wrong as Paul stated, but your remark about the
>> documentation is valid. So please post a clarifying doc patch against
>> qemu.git.
>>
>> Thanks,
>> Jan
>>
> 
> Hmm, OK. Is there any use case where -s is used without -S? GDB
> connecting at an arbitrary time during execution did not make sense to
> me. If I created a small patch with "nowait" as an option would you
> consider it? Most tcp connection options seem to have it.

No, -s makes a lot of sense (just like the corresponding gdbserver
monitor command): You can simply attach to the machine (in system
emulation) or application (in user mode) on demand, when you reached an
interesting point, when something went wrong, when the guest simply
locked up etc.

> 
> As per the docs, -S requires user to press 'c' to continue whereas
> with a waiting -s I can use a .gdbinit script to automate debugging.

Nothing prevents you from adding 'c' to your .gdbinit script, right
after the 'tar re :1234'.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]