qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option
Date: Wed, 10 Jun 2009 14:25:05 -0500	[thread overview]
Message-ID: <4A300891.4060500@codemonkey.ws> (raw)
In-Reply-To: <1244661817-3293-1-git-send-email-ehabkost@redhat.com>

Eduardo Habkost wrote:
> This new option may be used to disable the virtio-balloon device.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  hw/pc.c         |    2 +-
>  qemu-options.hx |    9 +++++++++
>  sysemu.h        |    1 +
>  vl.c            |    4 ++++
>  4 files changed, 15 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 0934778..aa92576 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1152,7 +1152,7 @@ static void pc_init1(ram_addr_t ram_size,
>      }
>  
>      /* Add virtio balloon device */
> -    if (pci_enabled) {
> +    if (pci_enabled && !no_virtio_balloon) {
>          pci_create_simple(pci_bus, -1, "virtio-balloon-pci");
>      }
>  
> diff --git a/qemu-options.hx b/qemu-options.hx
> index fa549c3..cb68e2a 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -681,6 +681,15 @@ Disable HPET support.
>  ETEXI
>  
>  #ifdef TARGET_I386
> +DEF("no-virtio-balloon", 0, QEMU_OPTION_no_virtio_balloon,
> +    "-no-virtio-baloon disable virtio balloon device\n")
>   
Missing 'l'.

Regards,

Anthony Liguori

  reply	other threads:[~2009-06-10 19:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 19:23 [Qemu-devel] [PATCH] Add -no-virtio-balloon command-line option Eduardo Habkost
2009-06-10 19:25 ` Anthony Liguori [this message]
2009-06-10 19:34   ` [Qemu-devel] " Eduardo Habkost
2009-06-11 10:07     ` Gerd Hoffmann
2009-06-15  9:25       ` Dor Laor
2009-06-15 11:04         ` Markus Armbruster
2009-06-15 12:54           ` Anthony Liguori
2009-06-15 13:40             ` Dor Laor
2009-06-15 13:46               ` Anthony Liguori
2009-06-15 18:07             ` Markus Armbruster
2009-06-15 18:14               ` Anthony Liguori
2009-06-26 17:15                 ` [Qemu-devel] [PATCH] Replace -no-virtio-balloon by -balloon Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A300891.4060500@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).