From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1METQD-0001YF-BV
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 15:25:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1METQ8-0001Sn-Pj
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 15:25:17 -0400
Received: from [199.232.76.173] (port=49584 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1METQ8-0001SO-Df
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 15:25:12 -0400
Received: from mail-ew0-f213.google.com ([209.85.219.213]:62228)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1METQ7-0007w7-Pp
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 15:25:12 -0400
Received: by ewy9 with SMTP id 9so1022004ewy.34
	for <qemu-devel@nongnu.org>; Wed, 10 Jun 2009 12:25:10 -0700 (PDT)
Message-ID: <4A300891.4060500@codemonkey.ws>
Date: Wed, 10 Jun 2009 14:25:05 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1244661817-3293-1-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1244661817-3293-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org

Eduardo Habkost wrote:
> This new option may be used to disable the virtio-balloon device.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  hw/pc.c         |    2 +-
>  qemu-options.hx |    9 +++++++++
>  sysemu.h        |    1 +
>  vl.c            |    4 ++++
>  4 files changed, 15 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 0934778..aa92576 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1152,7 +1152,7 @@ static void pc_init1(ram_addr_t ram_size,
>      }
>  
>      /* Add virtio balloon device */
> -    if (pci_enabled) {
> +    if (pci_enabled && !no_virtio_balloon) {
>          pci_create_simple(pci_bus, -1, "virtio-balloon-pci");
>      }
>  
> diff --git a/qemu-options.hx b/qemu-options.hx
> index fa549c3..cb68e2a 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -681,6 +681,15 @@ Disable HPET support.
>  ETEXI
>  
>  #ifdef TARGET_I386
> +DEF("no-virtio-balloon", 0, QEMU_OPTION_no_virtio_balloon,
> +    "-no-virtio-baloon disable virtio balloon device\n")
>   
Missing 'l'.

Regards,

Anthony Liguori