From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEjk4-0000xe-LH
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 08:50:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEjjz-0000wN-HD
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 08:50:51 -0400
Received: from [199.232.76.173] (port=51433 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEjjz-0000wC-4J
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 08:50:47 -0400
Received: from e38.co.us.ibm.com ([32.97.110.159]:50434)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1MEjjy-0006cz-Gc
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 08:50:46 -0400
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com
	[9.17.195.106])
	by e38.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5BClhaJ014575
	for <qemu-devel@nongnu.org>; Thu, 11 Jun 2009 06:47:43 -0600
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n5BCoeuB204120
	for <qemu-devel@nongnu.org>; Thu, 11 Jun 2009 06:50:40 -0600
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1])
	by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n5BCodrE020267
	for <qemu-devel@nongnu.org>; Thu, 11 Jun 2009 06:50:40 -0600
Message-ID: <4A30FD9E.9040200@us.ibm.com>
Date: Thu, 11 Jun 2009 07:50:38 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: Networking patches queue
References: <1243523971.4046.206.camel@blaa> <1244583818.7164.19.camel@blaa>
	<200906111248.22091.paul@codesourcery.com>
In-Reply-To: <200906111248.22091.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org, Alex Williamson <alex.williamson@hp.com>, Jan Kiszka <jan.kiszka@siemens.com>

Paul Brook wrote:
> On Tuesday 09 June 2009, Mark McLoughlin wrote:
>   
>>       net: add return value to packet receive handler (4f1c942b7f)
>>     
>
> This patch is wrong. We already have a can_receive handler for this purpose.  
> Having this callback and allowing receive to fail is just silly. One or the 
> other, but not both.
>   

How can can_receive fail for something like tap without actually trying 
to receive a packet?

If anything, we should just get rid of can_receive.

-- 
Regards,

Anthony Liguori