From: Gerd Hoffmann <kraxel@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] Add device tree machine
Date: Thu, 11 Jun 2009 15:33:00 +0200 [thread overview]
Message-ID: <4A31078C.9000403@redhat.com> (raw)
In-Reply-To: <20090610173821.4674.58171.stgit@wren.home>
A few more comments ...
> +static void dt_add_props(DeviceState *dev, void *dt, int offset)
> +{
Where do device properties come from? Only the fdt tree? If so, do we
need the property lists in the first place? We could get them directly
from the fdt tree instead.
> +static const DevicePropList i2c_bus_props[] = {
> + {.name = "address", .type = PROP_TYPE_INT},
> + {.name = NULL}
> +};
That could go into BusInfo as well.
cheers,
Gerd
next prev parent reply other threads:[~2009-06-11 13:35 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 17:38 [Qemu-devel] [PATCH 0/4] Machine config files Paul Brook
2009-06-10 17:38 ` [Qemu-devel] [PATCH 1/4] Include and build libfdt Paul Brook
2009-06-10 19:08 ` Glauber Costa
2009-06-10 19:23 ` Anthony Liguori
2009-06-10 19:27 ` Paul Brook
2009-06-10 19:41 ` Glauber Costa
2009-06-10 20:38 ` Paul Brook
2009-06-10 22:32 ` Edgar E. Iglesias
2009-06-10 19:34 ` Blue Swirl
2009-06-10 17:38 ` [Qemu-devel] [PATCH 2/4] Add device tree machine Paul Brook
2009-06-10 18:30 ` Blue Swirl
2009-06-10 19:10 ` Paul Brook
2009-06-11 13:22 ` Gerd Hoffmann
2009-06-11 13:33 ` Gerd Hoffmann [this message]
2009-06-11 13:39 ` Paul Brook
2009-06-11 14:22 ` Gerd Hoffmann
2009-06-12 16:25 ` Markus Armbruster
2009-06-10 17:38 ` [Qemu-devel] [PATCH 3/4] Stellaris machine config Paul Brook
2009-06-11 8:21 ` M P
2009-06-11 16:32 ` Jamie Lokier
2009-06-12 8:29 ` Gerd Hoffmann
2009-06-12 13:56 ` Markus Armbruster
2009-06-12 13:53 ` Markus Armbruster
2009-06-12 15:25 ` Jamie Lokier
2009-06-10 17:38 ` [Qemu-devel] [PATCH 4/4] Integrator " Paul Brook
2009-06-11 9:54 ` [Qemu-devel] [PATCH 0/4] Machine config files Gerd Hoffmann
2009-06-11 12:53 ` Gerd Hoffmann
2009-06-11 13:18 ` Paul Brook
2009-06-11 14:35 ` Gerd Hoffmann
2009-06-12 7:51 ` Kevin Wolf
2009-06-12 13:49 ` Markus Armbruster
2009-06-12 14:22 ` Kevin Wolf
2009-06-12 14:40 ` Markus Armbruster
2009-06-12 15:02 ` Anthony Liguori
2009-06-12 15:29 ` Kevin Wolf
2009-06-12 16:35 ` Blue Swirl
2009-06-12 13:37 ` Markus Armbruster
2009-06-12 14:44 ` Gerd Hoffmann
2009-06-12 15:58 ` Markus Armbruster
2009-06-12 16:11 ` [Qemu-devel] " Jan Kiszka
2009-07-06 12:49 ` Michael S. Tsirkin
2009-07-06 13:43 ` Gerd Hoffmann
2009-07-06 13:56 ` Michael S. Tsirkin
2009-07-06 14:01 ` Michael S. Tsirkin
2009-07-06 14:40 ` Gerd Hoffmann
2009-07-06 16:12 ` Avi Kivity
2009-07-06 16:27 ` Gerd Hoffmann
2009-07-06 16:37 ` Avi Kivity
2009-07-06 16:44 ` Michael S. Tsirkin
2009-07-07 4:47 ` Avi Kivity
2009-07-06 16:47 ` Paul Brook
2009-07-07 5:01 ` Avi Kivity
2009-07-06 17:28 ` Anthony Liguori
2009-07-06 22:39 ` Paul Brook
2009-07-06 23:13 ` Anthony Liguori
2009-07-07 5:00 ` Avi Kivity
2009-07-07 5:23 ` Avi Kivity
2009-07-07 4:56 ` Avi Kivity
2009-07-07 6:19 ` Michael S. Tsirkin
2009-07-06 14:24 ` Gerd Hoffmann
2009-07-06 14:31 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A31078C.9000403@redhat.com \
--to=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).