From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEqV7-0000Qo-1s
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 16:03:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEqV2-0000Q1-GH
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 16:03:52 -0400
Received: from [199.232.76.173] (port=51180 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEqV2-0000Pt-DG
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 16:03:48 -0400
Received: from qw-out-1920.google.com ([74.125.92.149]:39331)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MEqV1-0002hm-UJ
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 16:03:48 -0400
Received: by qw-out-1920.google.com with SMTP id 4so939953qwk.4
	for <qemu-devel@nongnu.org>; Thu, 11 Jun 2009 13:03:45 -0700 (PDT)
Message-ID: <4A31631E.8050603@codemonkey.ws>
Date: Thu, 11 Jun 2009 15:03:42 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC] Enable Werrror by default
References: <200906111335.10116.paul@codesourcery.com>	
	<1244726086.7752.25.camel@blaa>
	<4A314D2D.2060505@codemonkey.ws> <1244745525.4590.1.camel@blaa>
In-Reply-To: <1244745525.4590.1.camel@blaa>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

Mark McLoughlin wrote:
> On Thu, 2009-06-11 at 13:30 -0500, Anthony Liguori wrote:
>
>   
>> How about the following?  It currently only enables werror for Linux 
>> hosts and git builds.
>>
>>     
> ... 
>   
>> +# Consult white-list to determine whether to enable werror
>> +# by default.  Only enable by default for git builds
>> +if test -z "$werror" ; then
>> +    z_version=`cut -f3 -d. $source_path/VERSION`
>> +    if test "$z_version" = "50" -a \
>>     
>
> Looks good, except this will enable it in kvm-XX releases, and not in
> future stable branches.
>   

My main requirement is that I don't have to change anything when making 
a tarball release.

kvm releases carry a KVM_VERSION file that could be used to disable werror.

It's a good point about the stable branch though.  I don't know the best 
way to deal with that.  Disabling werror more than we could is certainly 
better than enabling it more than we should though.

> How about just 'test -d $source_path/.git/' ?
>   

Makes me a little nervous to add git-knowledge to configure.

Regards,

Anthony Liguori

> Cheers,
> Mark.
>
>