From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MFmBU-0007L9-3r for qemu-devel@nongnu.org; Sun, 14 Jun 2009 05:39:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MFmBP-0007JE-HK for qemu-devel@nongnu.org; Sun, 14 Jun 2009 05:39:27 -0400 Received: from [199.232.76.173] (port=35236 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MFmBO-0007J8-W1 for qemu-devel@nongnu.org; Sun, 14 Jun 2009 05:39:23 -0400 Received: from mx20.gnu.org ([199.232.41.8]:52502) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MFmBO-0000OU-IQ for qemu-devel@nongnu.org; Sun, 14 Jun 2009 05:39:22 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MFmBN-0002ih-Pr for qemu-devel@nongnu.org; Sun, 14 Jun 2009 05:39:22 -0400 Message-ID: <4A34C4C9.8030105@redhat.com> Date: Sun, 14 Jun 2009 12:37:13 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities] References: <20090610145540.GI19375@poweredge.glommer> <20090610150129.GC28601@redhat.com> <200906101624.30659.paul@codesourcery.com> <20090610174301.GC7416@shareable.org> <20090610182227.GN28601@redhat.com> <20090610192702.GH7416@shareable.org> <1244796209.16425.20.camel@blaa> <4A326C7E.3020309@codemonkey.ws> <1244822007.30522.68.camel@blaa> <20090614093411.GA6959@redhat.com> In-Reply-To: <20090614093411.GA6959@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Mark McLoughlin , kvm@vger.kernel.org, Carsten Otte , Glauber Costa , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl , Christian Borntraeger , Paul Brook Michael S. Tsirkin wrote: > > If we want to remove a device from under a running guest, you need > hotplug. So we can't just remove several lines from the config and hope > that it'll work simply because the PCI address is stable. > Why not? > OTOH, if you reboot the guest, it's ok for addresses to change. > No, it's not. Some guests depend on addressing for their configuration (for example older Linux guests will swap eth0/eth1 if you swap their slots). -- error compiling committee.c: too many arguments to function