From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MFvby-0007wR-5S for qemu-devel@nongnu.org; Sun, 14 Jun 2009 15:43:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MFvbt-0007td-Lb for qemu-devel@nongnu.org; Sun, 14 Jun 2009 15:43:25 -0400 Received: from [199.232.76.173] (port=54226 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MFvbt-0007ta-Fs for qemu-devel@nongnu.org; Sun, 14 Jun 2009 15:43:21 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:49576) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MFvbs-00016O-Qh for qemu-devel@nongnu.org; Sun, 14 Jun 2009 15:43:21 -0400 Message-ID: <4A3552CD.3070703@web.de> Date: Sun, 14 Jun 2009 21:43:09 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks References: <4A353BE2.5060204@web.de> <4A35403C.3020409@web.de> <5b31733c0906141146n7927cf77ga36ae0c455d501b0@mail.gmail.com> In-Reply-To: <5b31733c0906141146n7927cf77ga36ae0c455d501b0@mail.gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig6C0F5E4B2B412E23532B1CAB" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: Blue Swirl , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6C0F5E4B2B412E23532B1CAB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Filip Navara wrote: > On Sun, Jun 14, 2009 at 8:23 PM, Jan Kiszka wrote: >=20 >> Blue Swirl wrote: >>> On 6/14/09, Jan Kiszka wrote: >>>> [ I can't check the situation with cygwin, so this is mingw-only. ] >>>> >>>> gcc still does not support the Windows-specific format string modif= ier >>>> "I64". Therefore, it makes no sense to check for format string >>>> correctness and generate tons of false positives. >>> I don't have this problem, currently mingw builds with zero warnings >>> for me. But I didn't enable automatic -Werror flag for mingw just >>> because I guessed this would happen. What's the gcc version you're >>> using? >> i686-pc-mingw32-gcc (GCC) 4.3.3 >> >> Jan >> >> JFYI, for years there was a mingw32 patch for the format strings that > wasn't merged into the mainline gcc. It was in the MinGW patches for at= > least 4 years. Not sure if it was merged now or not.. > Best regards, > Filip Navara >=20 Yes, I've seen the patch while looking for the reason, but I didn't read that it is part of mingw's gcc version. Obviously, this toolchain does not contain it. Don't know where it was derived from (hmm, mingw is still "testing" gcc4...). I just picked what was there (for OpenSUSE) to include a simple win32 build run in future patch development. Well, if everyone else out there has I64 support, then I can also add this switch to my --extra-cflags. Jan --------------enig6C0F5E4B2B412E23532B1CAB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAko1UtUACgkQniDOoMHTA+kpngCfYbu7TtmdOJNsKegejoDk4P/t DhkAoIDB1fc+o42SbehoGsMcu38+uCEM =PAR/ -----END PGP SIGNATURE----- --------------enig6C0F5E4B2B412E23532B1CAB--