From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGBhp-0002yN-18
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 08:54:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGBhj-0002rX-K0
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 08:54:32 -0400
Received: from [199.232.76.173] (port=52326 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGBhj-0002qy-5Q
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 08:54:27 -0400
Received: from mail-qy0-f191.google.com ([209.85.221.191]:33070)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MGBhi-0006Qv-DJ
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 08:54:26 -0400
Received: by qyk29 with SMTP id 29so4525760qyk.4
	for <qemu-devel@nongnu.org>; Mon, 15 Jun 2009 05:54:25 -0700 (PDT)
Message-ID: <4A36447B.6030509@codemonkey.ws>
Date: Mon, 15 Jun 2009 07:54:19 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line
	option
References: <1244661817-3293-1-git-send-email-ehabkost@redhat.com>	<4A300891.4060500@codemonkey.ws>
	<20090610193408.GE18045@blackpad>	<4A30D748.8070507@redhat.com>
	<4A36138C.4060306@redhat.com> <87vdmx69na.fsf@pike.pond.sub.org>
In-Reply-To: <87vdmx69na.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

Markus Armbruster wrote:
> Dor Laor <dlaor@redhat.com> writes:
>
>   
>> Gerd Hoffmann wrote:
>>     
>>>> This new option may be used to disable the virtio-balloon device.
>>>>
>>>>         
>>> ACK, looks good.
>>>
>>> And I can drop my lazy patch which just comments out virtio-balloon
>>> in the code ;)
>>>       
>> Actually, I rather have the balloon disabled by default. It's like any
>> other pci device which needs
>> explicit command line specification. Why consume a pci slot if not
>> implicitly required?
>>     
>
> I agree.  The command line is plenty magic without implicitly added
> PCI devices.
>
> Besides, negative options -no-virtio-balloon lead to ugly
> double-negatives like if (!no_virtio_balloon).
>   

It does no harm to add the device by default so why force the user to 
explicitly enable it?

Regards,

Anthony Liguori