From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGCQP-0000Yp-FK
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 09:40:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGCQK-0000WQ-P1
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 09:40:36 -0400
Received: from [199.232.76.173] (port=56625 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGCQK-0000WM-KE
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 09:40:32 -0400
Received: from mx2.redhat.com ([66.187.237.31]:39605)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dlaor@redhat.com>) id 1MGCQJ-0006jc-I1
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 09:40:32 -0400
Message-ID: <4A364F61.8090406@redhat.com>
Date: Mon, 15 Jun 2009 16:40:49 +0300
From: Dor Laor <dlaor@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line
	option
References: <1244661817-3293-1-git-send-email-ehabkost@redhat.com>	<4A300891.4060500@codemonkey.ws>	<20090610193408.GE18045@blackpad>	<4A30D748.8070507@redhat.com>	<4A36138C.4060306@redhat.com>
	<87vdmx69na.fsf@pike.pond.sub.org> <4A36447B.6030509@codemonkey.ws>
In-Reply-To: <4A36447B.6030509@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: dlaor@redhat.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Anthony Liguori wrote:
> Markus Armbruster wrote:
>> Dor Laor <dlaor@redhat.com> writes:
>>
>>  
>>> Gerd Hoffmann wrote:
>>>    
>>>>> This new option may be used to disable the virtio-balloon device.
>>>>>
>>>>>         
>>>> ACK, looks good.
>>>>
>>>> And I can drop my lazy patch which just comments out virtio-balloon
>>>> in the code ;)
>>>>       
>>> Actually, I rather have the balloon disabled by default. It's like any
>>> other pci device which needs
>>> explicit command line specification. Why consume a pci slot if not
>>> implicitly required?
>>>     
>>
>> I agree.  The command line is plenty magic without implicitly added
>> PCI devices.
>>
>> Besides, negative options -no-virtio-balloon lead to ugly
>> double-negatives like if (!no_virtio_balloon).
>>   
>
> It does no harm to add the device by default so why force the user to 
> explicitly enable it?

It consumes one of the 32 pci devices we have today. It's the same for 
not having -usb as default
or any other type of device. Soon we'll need pci_addr= along with it 
anyway ;)

Dor