From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGE7C-0007cy-Sz for qemu-devel@nongnu.org; Mon, 15 Jun 2009 11:28:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGE75-0007a7-Kq for qemu-devel@nongnu.org; Mon, 15 Jun 2009 11:28:52 -0400 Received: from [199.232.76.173] (port=51761 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGE75-0007Zh-AK for qemu-devel@nongnu.org; Mon, 15 Jun 2009 11:28:47 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38600) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MGE74-0001cz-RJ for qemu-devel@nongnu.org; Mon, 15 Jun 2009 11:28:47 -0400 Message-ID: <4A366829.7060700@redhat.com> Date: Mon, 15 Jun 2009 18:26:33 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities] References: <20090610150129.GC28601@redhat.com> <200906101624.30659.paul@codesourcery.com> <20090610174301.GC7416@shareable.org> <20090610182227.GN28601@redhat.com> <20090610192702.GH7416@shareable.org> <1244796209.16425.20.camel@blaa> <4A326B5C.5010501@codemonkey.ws> <1244821292.30522.56.camel@blaa> <4A327E4A.7010300@codemonkey.ws> <1244825303.26769.19.camel@blaa> <20090614095016.GA7560@redhat.com> <4A3617D4.5090405@redhat.com> <4A36424D.3080901@codemonkey.ws> <4A364698.1090402@redhat.com> <4A364A9B.9070001@codemonkey.ws> <4A364E32.4010808@redhat.com> <4A365078.5080209@codemonkey.ws> <4A36529D.4060200@redhat.com> <4A3663C6.3070801@codemonkey.ws> <4A3664A0.6080105@redhat.com> <4A3666B5.2000104@codemonkey.ws> In-Reply-To: <4A3666B5.2000104@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Carsten Otte , Rusty Russell , kvm@vger.kernel.org, Mark McLoughlin , Glauber Costa , "Michael S. Tsirkin" , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl , Christian Borntraeger , Paul Brook On 06/15/2009 06:20 PM, Anthony Liguori wrote: > Avi Kivity wrote: >> I would prefer explicit names (pci_addr, lun, etc.) but would be okay >> with generic names too. > > I think having a generic address has a lot of value in terms of code > implementation. Otherwise, the valid options for -drive become > context-sensitive which is going to be annoying and error-prone. Some > sanity could be added by using addressing prefixes like > addr=pci:00:01.0 or addr=scsi:0.3 but I'll leave that up to whoever > takes this on. The code problems are easily solved by adding another level of indirection. User confusion problems are only aggravated by additional abstraction, though ("what do I put in addr=, here?"). -- error compiling committee.c: too many arguments to function