Re: [Qemu-devel] Register uhci_reset() callback.

[Avi Kivity <avi@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

On 06/15/2009 08:02 PM, Gleb Natapov wrote:
> On Mon, Jun 15, 2009 at 07:21:09PM +0300, Avi Kivity wrote:
>    
>> On 06/11/2009 04:46 PM, Gleb Natapov wrote:
>>      
>>> On Thu, Jun 11, 2009 at 02:41:33PM +0100, Paul Brook wrote:
>>>
>>>        
>>>> On Thursday 11 June 2009, Gleb Natapov wrote:
>>>>
>>>>          
>>>>> Update IRQ line on reset.
>>>>>
>>>>>            
>>>> This should not be necessary.
>>>>
>>>>
>>>>          
>>> You are always so brief.
>>>        
>> To be fair, so are you.
>>
>>      
> May be, but in this case after previous patch to reset interrupt level
> for each device at PCI bridge level was rejected on the premise that
> device should lower its own irq line on reset and since patches started
> flowing in to do just that, I did not expect that eloquent explanation
> would be needed for such trivial and obviously correct change.
>    

Citing which guests are unbroken by the patch, for example, would have 
helped.  As someone who accepts a lot of excellent patches from you, I 
also find the change logs to be laconic.

Of course, replies like "this should not be necessary" provide almost 
zero information and don't improve the situation.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


[-- Attachment #2: Type: text/html, Size: 1986 bytes --]