From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGICc-0003Tz-B5
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 15:50:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGICY-0003P8-1y
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 15:50:45 -0400
Received: from [199.232.76.173] (port=54624 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGICX-0003Ot-KI
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 15:50:41 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:34408)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MGICW-0001r4-T6
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 15:50:41 -0400
Message-ID: <4A36A60C.2000904@web.de>
Date: Mon, 15 Jun 2009 21:50:36 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks
References: <4A353BE2.5060204@web.de>
	<f43fc5580906141120t3d649885mf42c1bfbb3c550c@mail.gmail.com>
	<4A35403C.3020409@web.de>
	<alpine.DEB.1.00.0906142209250.26154@pacific.mpi-cbg.de>
In-Reply-To: <alpine.DEB.1.00.0906142209250.26154@pacific.mpi-cbg.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig77C1B06E376B2F450CC220EB"
Sender: jan.kiszka@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig77C1B06E376B2F450CC220EB
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Johannes Schindelin wrote:
> Hi,
>=20
> On Sun, 14 Jun 2009, Jan Kiszka wrote:
>=20
>> Blue Swirl wrote:
>>> On 6/14/09, Jan Kiszka <jan.kiszka@web.de> wrote:
>>>> [ I can't check the situation with cygwin, so this is mingw-only. ]
>>>>
>>>>  gcc still does not support the Windows-specific format string modif=
ier
>>>>  "I64". Therefore, it makes no sense to check for format string
>>>>  correctness and generate tons of false positives.
>>> I don't have this problem, currently mingw builds with zero warnings
>>> for me. But I didn't enable automatic -Werror flag for mingw just
>>> because I guessed this would happen. What's the gcc version you're
>>> using?
>> i686-pc-mingw32-gcc (GCC) 4.3.3
>=20
> 4.3.3 is known to show this bad behavior.  AFAICT it is fixed in 4.4.0.=
 =20
> (At least it fixed things for msysGit.)
>=20
> FWIW by "bad behavior" I mean that a compiler warning is emitted when=20
> using %I64, but not when using %ll.  But when executing the program, it=
=20
> actually _requires_ a %I64, _not_ a %ll.
>=20
> In light of this, I _strongly_ recommend updating to 4.4.0.

I will, once I come across a pre-built one that fits. For now I'll carry
the -Wno-format as extra flags. The toolchain performs nicely otherwise.

Thanks,
Jan


--------------enig77C1B06E376B2F450CC220EB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAko2pgwACgkQniDOoMHTA+lIiACfeq8KStKhghJ0Qav2/JhURcWE
0YEAnjITZcxaIYUGxM2ujk4XrbKXlJ7h
=h9K5
-----END PGP SIGNATURE-----

--------------enig77C1B06E376B2F450CC220EB--