From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGKs6-0007al-S2
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 18:41:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGKs2-0007ZM-83
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 18:41:46 -0400
Received: from [199.232.76.173] (port=47341 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGKs2-0007ZJ-5J
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 18:41:42 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:49828)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MGKs1-0004Mq-NS
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 18:41:41 -0400
Message-ID: <4A36CE1F.2080408@web.de>
Date: Tue, 16 Jun 2009 00:41:35 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <20090615173731.026e9fa9@doriath>
In-Reply-To: <20090615173731.026e9fa9@doriath>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig62A88420A8D4A076F282F995"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] readline: Remove unneeded qemu_mallocz()
	check
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig62A88420A8D4A076F282F995
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Luiz Capitulino wrote:
> qemu_mallocz() already checks for NULL returns, readline_init() doesn't=

> have to do it again.
>=20
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  readline.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>=20
> diff --git a/readline.c b/readline.c
> index 9c500f1..7834af0 100644
> --- a/readline.c
> +++ b/readline.c
> @@ -467,9 +467,6 @@ ReadLineState *readline_init(Monitor *mon,
>  {
>      ReadLineState *rs =3D qemu_mallocz(sizeof(*rs));
> =20
> -    if (!rs)
> -        return NULL;
> -
>      rs->hist_entry =3D -1;
>      rs->mon =3D mon;
>      rs->completion_finder =3D completion_finder;

Ack.

Jan


--------------enig62A88420A8D4A076F282F995
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAko2ziIACgkQniDOoMHTA+kymwCeKmyjFtrx3iokGsq2sn0tvAa+
hJ8An373jRL6tOkyzlZNY2v4nT9+Yz4O
=3Oe1
-----END PGP SIGNATURE-----

--------------enig62A88420A8D4A076F282F995--