[Qemu-devel] [PATCH] readline: Remove unneeded qemu_mallocz() check

[Qemu-devel] [PATCH] readline: Remove unneeded qemu_mallocz() check

[Luiz Capitulino]

qemu_mallocz() already checks for NULL returns, readline_init() doesn't
have to do it again.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 readline.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/readline.c b/readline.c
index 9c500f1..7834af0 100644
--- a/readline.c
+++ b/readline.c
@@ -467,9 +467,6 @@ ReadLineState *readline_init(Monitor *mon,
 {
     ReadLineState *rs = qemu_mallocz(sizeof(*rs));
 
-    if (!rs)
-        return NULL;
-
     rs->hist_entry = -1;
     rs->mon = mon;
     rs->completion_finder = completion_finder;
-- 
1.6.3.GIT

[Qemu-devel] Re: [PATCH] readline: Remove unneeded qemu_mallocz() check

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

Luiz Capitulino wrote:
> qemu_mallocz() already checks for NULL returns, readline_init() doesn't
> have to do it again.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  readline.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/readline.c b/readline.c
> index 9c500f1..7834af0 100644
> --- a/readline.c
> +++ b/readline.c
> @@ -467,9 +467,6 @@ ReadLineState *readline_init(Monitor *mon,
>  {
>      ReadLineState *rs = qemu_mallocz(sizeof(*rs));
>  
> -    if (!rs)
> -        return NULL;
> -
>      rs->hist_entry = -1;
>      rs->mon = mon;
>      rs->completion_finder = completion_finder;

Ack.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]