From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGKtg-0007ym-LQ for qemu-devel@nongnu.org; Mon, 15 Jun 2009 18:43:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGKtb-0007yW-BH for qemu-devel@nongnu.org; Mon, 15 Jun 2009 18:43:24 -0400 Received: from [199.232.76.173] (port=47367 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGKtb-0007yT-98 for qemu-devel@nongnu.org; Mon, 15 Jun 2009 18:43:19 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:38317) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MGKta-0004Zh-NJ for qemu-devel@nongnu.org; Mon, 15 Jun 2009 18:43:19 -0400 Message-ID: <4A36CE85.3040906@web.de> Date: Tue, 16 Jun 2009 00:43:17 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks References: <4A353BE2.5060204@web.de> <4A35403C.3020409@web.de> <4A36A60C.2000904@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9DCD0745A1A7BC9329B5290A" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Johannes Schindelin Cc: Blue Swirl , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9DCD0745A1A7BC9329B5290A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Johannes Schindelin wrote: > Hi, >=20 > On Mon, 15 Jun 2009, Jan Kiszka wrote: >=20 >> Johannes Schindelin wrote: >>> Hi, >>> >>> On Sun, 14 Jun 2009, Jan Kiszka wrote: >>> >>>> Blue Swirl wrote: >>>>> On 6/14/09, Jan Kiszka wrote: >>>>>> [ I can't check the situation with cygwin, so this is mingw-only. = ] >>>>>> >>>>>> gcc still does not support the Windows-specific format string mod= ifier >>>>>> "I64". Therefore, it makes no sense to check for format string >>>>>> correctness and generate tons of false positives. >>>>> I don't have this problem, currently mingw builds with zero warning= s >>>>> for me. But I didn't enable automatic -Werror flag for mingw just >>>>> because I guessed this would happen. What's the gcc version you're >>>>> using? >>>> i686-pc-mingw32-gcc (GCC) 4.3.3 >>> 4.3.3 is known to show this bad behavior. AFAICT it is fixed in 4.4.= 0. =20 >>> (At least it fixed things for msysGit.) >>> >>> FWIW by "bad behavior" I mean that a compiler warning is emitted when= =20 >>> using %I64, but not when using %ll. But when executing the program, = it=20 >>> actually _requires_ a %I64, _not_ a %ll. >>> >>> In light of this, I _strongly_ recommend updating to 4.4.0. >> I will, once I come across a pre-built one that fits. >=20 > The de-facto standard is http://www.tdragon.net/recentgcc/ This is pre-built, but for an uninteresting host platform (also known as Windows). :) Jan --------------enig9DCD0745A1A7BC9329B5290A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAko2zoUACgkQniDOoMHTA+lfDgCfca86GEjR1x/6hijsmEscpvaf aXoAn0ss/rqmB3gM+ByiXMC22r7TK/57 =t/ak -----END PGP SIGNATURE----- --------------enig9DCD0745A1A7BC9329B5290A--