qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	kvm-devel <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: Live migration broken when under heavy IO
Date: Tue, 16 Jun 2009 12:10:38 +0300	[thread overview]
Message-ID: <4A37618E.6040606@redhat.com> (raw)
In-Reply-To: <4A36B025.2080602@us.ibm.com>

On 06/15/2009 11:33 PM, Anthony Liguori wrote:
> The basic issue is that:
>
> migrate_fd_put_ready():    bdrv_flush_all();
>
> Does:
>
> block.c:
>
> foreach block driver:
>   drv->flush(bs);
>
> Which in the case of raw, is just fsync(s->fd).
>
> Any submitted request is not queued or flushed which will lead to the 
> request being dropped after the live migration.
>
> Is anyone working on fixing this? 

Not to my knowledge

> Does anyone have a clever idea how to fix this without just waiting 
> for all IO requests to complete?

What's wrong with waiting for requests to complete?  It should take a 
few tens of milliseconds.

We could start throttling requests late in the live stage, but I don't 
really see the point.

Isn't virtio migration currently broken due to the qdev changes?

-- 
error compiling committee.c: too many arguments to function

  parent reply	other threads:[~2009-06-16  9:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 20:33 [Qemu-devel] Live migration broken when under heavy IO Anthony Liguori
2009-06-15 20:48 ` Glauber Costa
2009-06-16  9:10 ` Avi Kivity [this message]
2009-06-16  9:13   ` [Qemu-devel] " Avi Kivity
2009-06-16 12:50   ` Anthony Liguori
2009-06-16 12:54     ` Avi Kivity
2009-06-16 12:57       ` Anthony Liguori
2009-06-16 13:12         ` Avi Kivity
2009-06-16 18:19 ` Charles Duffy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37618E.6040606@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).