From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGXLM-0003v6-NJ for qemu-devel@nongnu.org; Tue, 16 Jun 2009 08:00:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGXLF-0003qM-VD for qemu-devel@nongnu.org; Tue, 16 Jun 2009 08:00:45 -0400 Received: from [199.232.76.173] (port=37608 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGXLE-0003pu-6X for qemu-devel@nongnu.org; Tue, 16 Jun 2009 08:00:41 -0400 Received: from mx2.redhat.com ([66.187.237.31]:41024) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MGXLC-0004UW-Ou for qemu-devel@nongnu.org; Tue, 16 Jun 2009 08:00:39 -0400 Message-ID: <4A37896C.8050208@redhat.com> Date: Tue, 16 Jun 2009 15:00:44 +0300 From: Avi Kivity MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Regression opening read-only cdroms List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel qemu used to be quite happy opening read-only cdrom images, and I was quite happy feeding kvm-autotest a library of read-only iso images. However since commit 0e1d8f4c549e51fd19793a154862979fdc199477 Author: Christoph Hellwig Date: Mon Jun 15 13:53:26 2009 +0200 raw-posix: always store open flags Both the Linux floppy and the FreeBSD CDROM host device need to store the open flags so that they can re-open the device later. Store the open flags unconditionally to remove the ifdef mess and simply the calling conventions for the later patches in the series. Signed-off-by: Christoph Hellwig this state of happiness no longer exists. Can you look at what caused this? -- error compiling committee.c: too many arguments to function