qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] Regression opening read-only cdroms
Date: Tue, 16 Jun 2009 15:54:55 +0100	[thread overview]
Message-ID: <4A37B23F.6040604@eu.citrix.com> (raw)
In-Reply-To: <20090616143259.GA29040@shareable.org>

Jamie Lokier wrote:

> Avi Kivity wrote:
>> qemu used to be quite happy opening read-only cdrom images, and I was 
>> quite happy feeding kvm-autotest a library of read-only iso images.
> 
> 1. While we're here, an _option_ to open an image read-only even when
>    you have write permission would be useful, for those occasions when
>    you want to boot from some valuable image and be certain you aren't
>    modifying it - without having to chmod back and forth in
>    Qemu-wrapper scripts, or copy the image first.


Indeed.
I have a patch that adds bdrv_set_read_only that set bs->read_only = 1
so that bdrv_open2 can check if the flag is set and act accordingly.
The problem is that in xen we read whether the device should be opened
read only in the VM config file, I don't think the user can specify to
open a drive read-only in qemu.

 
> 2. Would it make sense to open CD-ROM images read-only all the time,
>    when they are opened with media=cdrom, or can QEMU's CD-ROM devices
>    write to the images?
> 

not at the moment, it may  be possible in the future.

  reply	other threads:[~2009-06-16 14:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 12:00 [Qemu-devel] Regression opening read-only cdroms Avi Kivity
2009-06-16 14:33 ` Jamie Lokier
2009-06-16 14:54   ` Stefano Stabellini [this message]
2009-06-16 14:54     ` Jamie Lokier
2009-06-16 16:28       ` Anthony Liguori
2009-06-16 17:14         ` Stefano Stabellini
2009-06-16 17:46           ` Jamie Lokier
2009-06-16 17:54             ` Avi Kivity
2009-06-16 18:56               ` Jamie Lokier
2009-06-16 19:02                 ` Jamie Lokier
2009-06-16 21:11         ` Gerd Hoffmann
2009-06-17  6:27           ` Avi Kivity
2009-06-16 15:16   ` Avi Kivity
2009-06-16 15:54     ` Jamie Lokier
2009-06-16 16:17       ` Avi Kivity
2009-06-16 17:51         ` Jamie Lokier
2009-06-16 17:58           ` Avi Kivity
2009-06-18 12:37   ` Richard W.M. Jones
2009-06-24 20:23     ` Jamie Lokier
2009-06-24 22:43       ` Richard W.M. Jones
2009-06-25  0:50         ` Jamie Lokier
2009-06-25  8:17           ` Richard W.M. Jones
2009-06-16 16:28 ` Blue Swirl
2009-06-16 18:37   ` Blue Swirl
2009-06-16 21:16     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37B23F.6040604@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=avi@redhat.com \
    --cc=hch@lst.de \
    --cc=jamie@shareable.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).