[Qemu-devel] [PATCH] configure: Append extra cflags and ldflags

[Qemu-devel] [PATCH] configure: Append extra cflags and ldflags

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

In order to allow overriding flags that are set by configure, we have to
append them instead of prepending as it is done so far.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

 configure |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index 85bc598..eb687bf 100755
--- a/configure
+++ b/configure
@@ -380,9 +380,9 @@ for opt do
   ;;
   --install=*) install="$optarg"
   ;;
-  --extra-cflags=*) CFLAGS="$optarg"
+  --extra-cflags=*) EXTRA_CFLAGS="$optarg"
   ;;
-  --extra-ldflags=*) LDFLAGS="$optarg"
+  --extra-ldflags=*) EXTRA_LDFLAGS="$optarg"
   ;;
   --cpu=*) cpu="$optarg"
   ;;
@@ -1432,8 +1432,8 @@ echo "OS_CFLAGS=$OS_CFLAGS" >> $config_mak
 echo "OS_LDFLAGS=$OS_LDFLAGS" >> $config_mak
 echo "ARCH_CFLAGS=$ARCH_CFLAGS" >> $config_mak
 echo "ARCH_LDFLAGS=$ARCH_LDFLAGS" >> $config_mak
-echo "CFLAGS=$CFLAGS" >> $config_mak
-echo "LDFLAGS=$LDFLAGS" >> $config_mak
+echo "CFLAGS=$CFLAGS $EXTRA_CFLAGS" >> $config_mak
+echo "LDFLAGS=$LDFLAGS $EXTRA_LDFLAGS" >> $config_mak
 echo "EXESUF=$EXESUF" >> $config_mak
 echo "PTHREADLIBS=$PTHREADLIBS" >> $config_mak
 echo "CLOCKLIBS=$CLOCKLIBS" >> $config_mak


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

[Qemu-devel] Re: [PATCH] configure: Append extra cflags and ldflags

[Blue Swirl]

On 6/15/09, Jan Kiszka <jan.kiszka@web.de> wrote:
> In order to allow overriding flags that are set by configure, we have to
>  append them instead of prepending as it is done so far.

The help message from configure does not mention about overriding but
adding flags. Which one is this?

[Qemu-devel] Re: [PATCH] configure: Append extra cflags and ldflags

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

Blue Swirl wrote:
> On 6/15/09, Jan Kiszka <jan.kiszka@web.de> wrote:
>> In order to allow overriding flags that are set by configure, we have to
>>  append them instead of prepending as it is done so far.
> 
> The help message from configure does not mention about overriding but
> adding flags. Which one is this?

I didn't derive this from the help, but from common practice when using
EXTRA_* flags and the fact the gcc switches that come last override what
comes first. Without the patch, adding your personal -W* switches to the
build is impossible when they collide with some set by configure.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

Re: [Qemu-devel] [PATCH] configure: Append extra cflags and ldflags

[Avi Kivity]

On 06/15/2009 11:09 PM, Jan Kiszka wrote:
> In order to allow overriding flags that are set by configure, we have to
> append them instead of prepending as it is done so far.
>    

Ah, this is useful for -O0 when debugging.

-- 
error compiling committee.c: too many arguments to function