From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGeCN-0000Ez-I4 for qemu-devel@nongnu.org; Tue, 16 Jun 2009 15:19:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGeCI-0000Di-PB for qemu-devel@nongnu.org; Tue, 16 Jun 2009 15:19:59 -0400 Received: from [199.232.76.173] (port=38039 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGeCI-0000DV-GB for qemu-devel@nongnu.org; Tue, 16 Jun 2009 15:19:54 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:55601) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MGeCI-0000gU-5r for qemu-devel@nongnu.org; Tue, 16 Jun 2009 15:19:54 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e38.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5GJGjJE021397 for ; Tue, 16 Jun 2009 13:16:45 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5GJJkmA230300 for ; Tue, 16 Jun 2009 13:19:46 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5GJJjXd010176 for ; Tue, 16 Jun 2009 13:19:46 -0600 Message-ID: <4A37F050.4070303@us.ibm.com> Date: Tue, 16 Jun 2009 14:19:44 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Register usb-uhci reset function. References: <20090616124702.GS19508@redhat.com> In-Reply-To: <20090616124702.GS19508@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org Gleb Natapov wrote: > Update irq line on reset. Reseting irq line is required because > racing irq from pci device will call piix3_set_irq(). piix3_set_irq() > will remember current level in pci_irq_levels[]. The PIC line will be > triggered if one of pci_irq_levels[] is set (depends on piix3 config). > If for instance pci_irq_levels[0] and pci_irq_levels[1] are mapped to > the same PIC irq and during reset pci_irq_levels[1] == 1, but device > that drives pci_irq_levels[0] is initialized first the device driver > will not be able to lower irq line. > > Without this patch RHEL4.8 hangs after reboot because usb interrupt > does not go away. > This breaks the build because... > @@ -346,6 +346,7 @@ static void uhci_reset(UHCIState *s) > + qemu_register_reset(uhci_reset, 0, s); > qemu_register_reset takes void (*)(void *) and you're passing void (*)(UHCIState *). -- Regards, Anthony Liguori