From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGfSR-0003ae-DS for qemu-devel@nongnu.org; Tue, 16 Jun 2009 16:40:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGfSN-0003ZA-OX for qemu-devel@nongnu.org; Tue, 16 Jun 2009 16:40:39 -0400 Received: from [199.232.76.173] (port=48623 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGfSN-0003Z5-KV for qemu-devel@nongnu.org; Tue, 16 Jun 2009 16:40:35 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:35202) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MGfSN-0004SM-65 for qemu-devel@nongnu.org; Tue, 16 Jun 2009 16:40:35 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e37.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5GKdq3I003900 for ; Tue, 16 Jun 2009 14:39:52 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5GKeHJX111752 for ; Tue, 16 Jun 2009 14:40:19 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5GKeFno006101 for ; Tue, 16 Jun 2009 14:40:16 -0600 Message-ID: <4A38032D.5060506@us.ibm.com> Date: Tue, 16 Jun 2009 15:40:13 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20090610122804.GB27174@redhat.com> In-Reply-To: <20090610122804.GB27174@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCHv4 01/13] qemu: make default_write_config use mask table List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Carsten Otte , kvm@vger.kernel.org, Glauber Costa , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl , Christian Borntraeger , Paul Brook , Avi Kivity Michael S. Tsirkin wrote: > Change much of hw/pci to use symbolic constants and a table-driven > design: add a mask table with writable bits set and readonly bits unset. > Detect change by comparing original and new registers. > > This makes it easy to support capabilities where read-only/writeable > bit layout differs between devices, depending on capabilities present. > > As a result, writing a single byte in BAR registers now works as > it should. Writing to upper limit registers in the bridge > also works as it should. Code is also shorter. > > Signed-off-by: Michael S. Tsirkin This series introduces warning (virtio_load decl/def does not match). -- Regards, Anthony Liguori