From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGfi8-0000fB-QL
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 16:56:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGfi4-0000bw-22
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 16:56:52 -0400
Received: from [199.232.76.173] (port=46147 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGfi3-0000bg-R5
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 16:56:47 -0400
Received: from mail-qy0-f191.google.com ([209.85.221.191]:35917)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MGfi3-00084m-C8
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 16:56:47 -0400
Received: by qyk29 with SMTP id 29so5871681qyk.4
	for <qemu-devel@nongnu.org>; Tue, 16 Jun 2009 13:56:46 -0700 (PDT)
Message-ID: <4A38070B.1020809@codemonkey.ws>
Date: Tue, 16 Jun 2009 15:56:43 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] avoid compilation warning/errors on up to
	date compilers
References: <200906160530.37086.jcd@tribudubois.net>	<20090616150343.GA4350@kos.to>
	<20090616182359.GA17188@miranda.arrow>
In-Reply-To: <20090616182359.GA17188@miranda.arrow>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: qemu-devel@nongnu.org

Stuart Brady wrote:
> On Tue, Jun 16, 2009 at 06:03:43PM +0300, Riku Voipio wrote:
>   
>> Which tree against did you make these changes? the qemu-ndb.c bit didn't
>> apply against HEAD. Also, there are some whitespace/tab issues. See the
>> CODING_STYLE doc. Functionally I can verify it removes compiler warnings
>> when using a modenr glibc (2.9).
>>     
>
> Unfortunately, some of the changes don't look right.
>   

I think adding -D_FORTIFY_SOURCE=1 to CFLAGS is probably a better fix 
than adding broken error handling everywhere.

Regards,

Anthony Liguori